import: Fix import of Stream.creator field. #30081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszmandera
commented
May 14, 2024
Comment on lines
+1019
to
+1023
| imported_hamlet_user = UserProfile.objects.get( | ||
| delivery_email=self.example_email("hamlet"), realm=imported_realm | ||
| ) | ||
| imported_denmark_stream = Stream.objects.get(name="Denmark", realm=imported_realm) | ||
| self.assertEqual(imported_denmark_stream.creator, imported_hamlet_user) |
There was a problem hiding this comment.
Apparently this doesn't actually fail without the fix above; because tests run inside a transaction. Not sure how to simulate the real situation in this test reasonably... But verified manually that the original code fails to import if there's a stream with .creator set, and after this fix it's able to be imported correctly.
There was a problem hiding this comment.
Probably that's good enough.
There was a problem hiding this comment.
#30082 fails(error) without this fix.
When importing a Stream, UserProfiles don't yet exist. so trying to import stream.creator fails with something like: ``` psycopg2.errors.ForeignKeyViolation: insert or update on table "zerver_stream" violates foreign key constraint "zerver_stream_creator_id_65aeba7e_fk_zerver_userprofile_id" DETAIL: Key (creator_id)=(5) is not present in table "zerver_userprofile". ```
mateuszmandera
force-pushed
the
stream-creator-import
branch
from
675ac63
to
0f0677b
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a Stream, UserProfiles don't yet exist. so trying to import stream.creator fails with something like: