Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove denominator in character counter #28706

Closed
3 tasks
alya opened this issue Jan 25, 2024 · 10 comments · Fixed by #29830
Closed
3 tasks

Remove denominator in character counter #28706

alya opened this issue Jan 25, 2024 · 10 comments · Fixed by #29830
Labels
area: compose (misc) redesign Part of the webapp redesign project, including blockers.

Comments

@alya
Copy link
Contributor

alya commented Jan 25, 2024

At present, when a message is close to or above the character limit, we display a character counter like this:

Screenshot 2024-01-24 at 9 38 06 PM Screenshot 2024-01-24 at 9 38 00 PM

Instead, we should:

It's OK to submit a PR covering just the first two points, or just the third point.

There are no changes in the logic of when to show the counter, or whether it's yellow or red.

CZO discussion

@alya alya added help wanted area: compose (misc) redesign Part of the webapp redesign project, including blockers. labels Jan 25, 2024
@zulipbot
Copy link
Member

Hello @zulip/design members, this issue was labeled with the "redesign" label, so you may want to check it out!

@alya alya mentioned this issue Jan 25, 2024
15 tasks
@alya alya removed the help wanted label Jan 25, 2024
@shivamgupta2020
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Hello @shivamgupta2020!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@shivamgupta2020
Copy link

@alya I want to try this issue, can u assign this to me.

@ankitsuryawanshi9892
Copy link
Collaborator

@alya I think this is the desired behaviour
image
image
image

@ankitsuryawanshi9892
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @ankitsuryawanshi9892!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@Chohankoti
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @Chohankoti!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 13, 2024
This commit refactors the  function to . The logic for handling if remaining characters less than 0 than show exceeded msg and else condition show remainingCharacters. This change simplifies the code while ensuring clarity in different scenarios of remaining characters.

Additionally, the tooltip associated with the character counter has been updated to display 'Maximum message length: 10000 characters.'

Fixes: zulip#28706
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 13, 2024
…ion to . The logic for handling if remaining characters less than 0 than show exceeded msg and else condition show remainingCharacters. This change simplifies the code while ensuring clarity in different scenarios of remaining characters.

Additionally, the tooltip associated with the character counter has been updated to display 'Maximum message length: 10000 characters.'

Fixes: zulip#28706
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 13, 2024
…ion to . The logic for handling if remaining characters less than 0 than show exceeded msg and else condition show remainingCharacters. This change simplifies the code while ensuring clarity in different scenarios of remaining characters.

Additionally, the tooltip associated with the character counter has been updated to display 'Maximum message length: 10000 characters.'

Fixes: zulip#28706
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

In this commit, the check_overflow_text function has been modified. The logic now handles scenarios where remaining characters are less than 0 by displaying an exceeded message; otherwise, it shows the remaining characters. This simplification ensures clarity in various scenarios.

Additionally, the tooltip for the character counter now displays Maximum message length: 10000 characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

In this commit, the check_overflow_text function has been modified. The logic now handles scenarios where remaining characters are less than 0 by displaying an exceeded message; otherwise, it shows the remaining characters. This simplification ensures clarity in various scenarios.

Additionally, the tooltip for the character counter now displays Maximum message length: 10000 characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

This commit optimization in compose_validate.js manages cases where text.length exceeds max_length, displaying exceeded messages and negative exceeded characters, and tooltip message is updated to 'Maximum message length: 10000 characters.’This simplification enhances clarity by displaying only the remaining characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

This commit optimization in compose_validate.js manages cases where text.length exceeds max_length, displaying exceeded messages and negative exceeded characters, and tooltip message is updated to 'Maximum message length: 10000 characters.’This simplification enhances clarity by displaying only the remaining characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

This commit optimization in compose_validate.js manages cases where text.length exceeds max_length, displaying exceeded messages and negative exceeded characters, and tooltip message is updated to 'Maximum message length: 10000 characters.’This simplification enhances clarity by displaying only the remaining characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 14, 2024
Fixes: zulip#28706

This commit optimization in compose_validate.js manages cases where text.length exceeds max_length, displaying exceeded messages and negative exceeded characters, and tooltip message is updated to 'Maximum message length: 10000 characters.’This simplification enhances clarity by displaying only the remaining characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 15, 2024
Fixes: zulip#28706

This commit optimization check_overflow_text function(compose_validate.js) manages cases where text.length exceeds max_length, displaying exceeded messages and negative exceeded characters, and tooltip message is updated to 'Maximum message length: 10000 characters.’This simplification enhances clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 15, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 15, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 16, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 16, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 16, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 23, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remainingCharacters variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
amaranand360 added a commit to amaranand360/zulip that referenced this issue Feb 26, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remaining_length variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
@Thanush19
Copy link
Collaborator

hey @alya , if the issue is not resolved ,i can work on this

amaranand360 added a commit to amaranand360/zulip that referenced this issue Mar 31, 2024
Fixes: zulip#28706

This commit Optimizes the function without altering the core logic. Improves handling for text length exceeding max_length, displaying the negative count of exceeded characters. In the else if condition, when text length reaches 90%, it shows only the remaining characters. Introduces the remaining_length variable. This simplification improves clarity by showing the remaining characters and negative value of exceeded characters.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 24, 2024
Additionally, the text colors have been updated for both light and dark
themes, it starts showing when 900 or less characters are left, as 999
was too soon, and has a tooltip to show the maximum characters limit.

Fixes: zulip#28706.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 28, 2024
Additionally, the text colors have been updated for both light and dark
themes, it starts showing when 900 or less characters are left, as 999
was too soon, and has a tooltip to show the maximum characters limit.

Fixes: zulip#28706.
timabbott pushed a commit to N-Shar-ma/zulip that referenced this issue Apr 29, 2024
Additionally, the text colors have been updated for both light and dark
themes, it starts showing when 900 or less characters are left, as 999
was too soon, and has a tooltip to show the maximum characters limit.

Fixes: zulip#28706.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 30, 2024
Additionally, the text colors have been updated for both light and dark
themes, it starts showing when 900 or less characters are left, as 999
was too soon, and has a tooltip to show the maximum characters limit.

Fixes: zulip#28706.
timabbott pushed a commit that referenced this issue Apr 30, 2024
Additionally, the text colors have been updated for both light and dark
themes, it starts showing when 900 or less characters are left, as 999
was too soon, and has a tooltip to show the maximum characters limit.

Fixes: #28706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compose (misc) redesign Part of the webapp redesign project, including blockers.
Projects
Status: Done
6 participants