Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: Remove denominator in character counter #28836

Closed
wants to merge 3 commits into from
Closed

compose: Remove denominator in character counter #28836

wants to merge 3 commits into from

Conversation

ankitsuryawanshi9892
Copy link
Collaborator

Previously when a message is close to or above the character limit, character counter is displayed in this format: text_length/max_length. This PR removes the denominator and display the number of characters remaining or the number of characters over the limit. Also tooltip is added to help users understand why the send button is disabled. This PR solves the issue #28706

Fixes: #28706

Screenshots and screen captures:
image
image
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Previously when a message is close to or above the character limit, character
counter is displayed in this format: text_length/max_length. This PR removes
the denominator and display the number of characters remaining or the number of
characters over the limit. Also tooltip is added to help users understand why
the send button is disabled. This PR solves the issue #28706
This was causing the check to fail. That's why this commit adds
extra newline at the end
Modified compose_validate.test.js because the test was failed
in previous commit
@N-Shar-ma
Copy link
Collaborator

@ankitsuryawanshi9892 Are you still working on this? You 1st need to lint your code with the command described in the error message.

@ankitsuryawanshi9892
Copy link
Collaborator Author

@N-Shar-ma Yes I am working on this, backend tests are failing...

@ankitsuryawanshi9892 ankitsuryawanshi9892 closed this by deleting the head repository Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants