Add encoding to job spool operations #1822
Conversation
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 636 636
Lines 19035 19040 +5
Branches 4009 4011 +2
=======================================
+ Hits 17346 17351 +5
Misses 1688 1688
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok and
ATorrise
packages/cli/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to the Zowe CLI package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - Enhancement: Added the ability to download job spool files using other codepages with `--encoding` on the `zowe jobs download output`, `zowe jobs view spool-file-by-id` and `zowe jobs view all-spool-content` commands. [#1822](https://github.com/zowe/zowe-cli/pull/1822) | |||
There was a problem hiding this comment.
Could we add a benefit to the user to this note? What does this change accomplish?
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
| @@ -35,6 +35,7 @@ describe("zos-jobs view spool-file-by-id handler", () => { | |||
|
|
|||
| afterEach(() => { | |||
| jest.resetAllMocks(); | |||
| DEFAULT_PARAMETERS.arguments.encoding = undefined; // Why is this needed? Where are things being set??? | |||
There was a problem hiding this comment.
Is this a todo comment or is it ok to leave for now? 😋
There was a problem hiding this comment.
Well, I wrote that 7 months ago, so I don't really know. I vaguely recall being frustrated because I could not find where that parameter was being set.
There was a problem hiding this comment.
I figured it out, it was because we weren't deep cloning objects, but were instead assigning them to new objects. The sub-objects were being passed by reference and polluting the results of other tests. We might want to look into any instances where we are using Object.assign({}, in the future.
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
|
What It Does
Add encoding option to download and view of job spool files
How to Test
Run automated tests, or download a spool file with a different encoding
Review Checklist
I certify that I have:
Additional Comments