Merge master into next #2142
Merged
Merge master into next #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Create dco.yml
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Reinstate token precedence over password in AbstractRestClient
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
[v2] Fix pre-commit script to support Git worktrees
Fix macOS tgz containing extra `GNUSparseFile.0` directory
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Show strings instead of regexes for allowed values in CLI help
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Add encoding to job spool operations
…oding Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Add encoding to Submit Jobs CLI and APIs (local-file and stdin)
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok and
ATorrise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2142 +/- ##
=======================================
Coverage 91.20% 91.21%
=======================================
Files 628 628
Lines 17877 17888 +11
Branches 3750 3689 -61
=======================================
+ Hits 16305 16316 +11
Misses 1571 1571
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
zFernand0
approved these changes
May 16, 2024
| @@ -366,13 +367,14 @@ export class GetJobs { | |||
| * @returns {Promise<string>} - promise that resolves to the spool content | |||
| * @memberof GetJobs | |||
| */ | |||
| public static async getSpoolContentById(session: AbstractSession, jobname: string, jobid: string, spoolId: number) { | |||
| public static async getSpoolContentById(session: AbstractSession, jobname: string, jobid: string, spoolId: number, encoding?: string) { | |||
There was a problem hiding this comment.
Should we move the params to a typed object? (in V3)
There was a problem hiding this comment.
I was thinking that any changes to interfaces and parameters would be a different story, since this was primarily meant to get the two branches reconciled. It might be nice to do that change on this API....
| @@ -106,16 +106,23 @@ export class SubmitJobs { | |||
| * @returns {Promise<IJob>} - Promise that resolves to an IJob document with details about the submitted job | |||
| * @memberof SubmitJobs | |||
| */ | |||
| public static submitJcl(session: AbstractSession, jcl: string, internalReaderRecfm?: string, internalReaderLrecl?: string) { | |||
| public static submitJcl(session: AbstractSession, jcl: string, internalReaderRecfm?: string, | |||
There was a problem hiding this comment.
Same as previous commnet...
Should we move everything after jcl (or include jcl too) into a typed object (with its own interface)?
This can be done in V3, and we can follow the example of submitJobCommon in this file 😋
There was a problem hiding this comment.
...however, on this API, we already call submitJclCommon. Frankly, I think it would be nice to just get rid of some of these redundant APIs, since they all do relatively similar things. At least for submitJCL, the change would be relatively small, since all we did was print a trace message, then call submitJclCommon with the same parameters.
ATorrise
approved these changes
May 16, 2024
traeok
approved these changes
May 16, 2024
t1m0thyj
approved these changes
May 16, 2024
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Updates Next to contain the following enhancements and bug fixes from Master:
GNUSparseFile.0directory #2126How to Test
Review Checklist
I certify that I have:
Additional Comments