-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose for Zanata 4.2+ #23
Conversation
docker-compose.yml as a scripts replacement
d7a3dd5
to
67f30a4
Compare
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Can you add those variables to the .env file (perhaps commented)?
|
@tholu Can you elaborate? I don't think putting them in the .env file file would do anything by itself, because "Environment variables defined in the .env file are not automatically visible inside containers." - https://docs.docker.com/compose/env-file/#compose-file-and-cli-variables I think it would be best to tackle these extras in a separate pull request. |
@seanf Of course they would have to be provided in the
|
Based on #20 and parts of https://github.com/jurikolo/zanata/blob/3906624e35b5aa8fae355d3e305f4e226afa6807/docker-compose.yml.
This docker-compose file uses v2.1 format, which is available in Docker 1.13.1+ (Fedora 26+). https://docs.docker.com/compose/compose-file/compose-versioning/
This change is