Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZNTA-1471) add docker-compose.yml #20

Closed
wants to merge 1 commit into from

Conversation

SlavikZ
Copy link
Contributor

@SlavikZ SlavikZ commented Mar 27, 2017

Jira Issue: ZNTA-1471

Add docker-compose.yml file as runapp.sh, rundb.sh scripts replacement for those who prefer to use docker-compose tool.


This change is Reviewable

docker-compose.yml as a scripts replacement
@alex-sl-eng alex-sl-eng assigned seanf and unassigned seanf Mar 27, 2017
@alex-sl-eng alex-sl-eng requested a review from seanf March 27, 2017 21:48
@carlosmunoz carlosmunoz requested review from carlosmunoz and removed request for seanf March 28, 2017 03:10
@seanf seanf changed the title Add docker-compose.yml feat(ZNTA-1471) add docker-compose.yml Jun 20, 2017
@seanf
Copy link
Contributor

seanf commented Jun 29, 2017

See also #23, since Fedora 24 (for one) doesn't support docker-compose 2.1 files. But I think there are other problems relating to Zanata 4.2.1 (and/or Docker 1.10+) which we also need to deal with.

@carlosmunoz
Copy link
Member

@seanf so what's the plan for this PR?

@seanf
Copy link
Contributor

seanf commented Jun 30, 2017

The first step is for someone should see if they can get the Zanata 4.2.1 image to work with Docker 1.10+. Then we can decide between #20 and #23.

Unfortunately @definite is on leave. I'm not sure what combinations he tested for Zanata 4.2.1.

@jurikolo
Copy link

Hey,
I've adjusted initial docker-compose with support for docker in Fedora 27. Sources: https://github.com/jurikolo/zanata/blob/master/docker-compose.yml

@carlosmunoz
Copy link
Member

@seanf @djansen-redhat @spathare21 This has been dormant for a while. What's the plan with this PR?

@tholu
Copy link
Contributor

tholu commented Nov 22, 2017

Would be really nice to have this as well, we have been fighting with Zanata Docker images as well.

@seanf
Copy link
Contributor

seanf commented Nov 23, 2017

@jurikolo Were your changes to take advantage of improvements in Fedora 27, or did @SlavikZ 's version break on Fedora 27?

It appears that docker-compose v3 files don't support depends_on with health checks, so it would be a shame to lose that. peter-evans/docker-compose-healthcheck#3 (comment)

@seanf
Copy link
Contributor

seanf commented Nov 23, 2017

Please see #23 which is based on this PR. Thanks @SlavikZ and @jurikolo

@seanf seanf closed this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants