Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized installation Script #1007

Open
wants to merge 1 commit into
base: release/2.1.0
Choose a base branch
from

Conversation

4NK1T
Copy link

@4NK1T 4NK1T commented Oct 20, 2023

No description provided.

@AnonymousWP
Copy link
Collaborator

Could you specify in your PR what exactly has been changed? That's easier when I'm going through the code.

@4NK1T
Copy link
Author

4NK1T commented Oct 24, 2023

Function for Logging (3-7)
Root priveleges check using the "id -u" check more efficiently (9-15)
Output messages are grouped into sections using the log function (19-48)
Dependencies (CURL, Docker, docker-compose, make) are checked and installed more efficiently in a single section (50-70)
Docker status is checked using "docker info" with more detailed error messages.
Installation success and failure are checked with conditional statements and better error handling.

@AnonymousWP
Copy link
Collaborator

Sounds great. Have you tested this thoroughly too? e.g. without having installed make, Docker Compose, Docker, etc? In short: does everything work?

@4NK1T
Copy link
Author

4NK1T commented Oct 25, 2023

Yes tried and tested twice.

Copy link
Collaborator

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It currently conflicts with #973. Could you actually merge/integrate that change into your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.1.0 Waiting for Merge Already Worked, waiting to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants