Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops(docker): arm64 support & improvement for smoother install/uninstall #66

Closed

Conversation

psyray
Copy link

@psyray psyray commented May 2, 2024

This PR brings the ARM64 arch build official !

I've also improved the docker generation and the install script based on the @vncloudsco, @4NK1T & @sa7mon PR proposed on reNgine
yogeshojha#1007
yogeshojha#1212
yogeshojha#1210

Improved:

  • Container now doing health check on the depending container before starting
    I make the install smoother, because while testing I've seen a lot of migration problem due to the db container not starting so fast.

Now:

  1. The db and the redis container are health checked,
  2. Then, the celery starts, doing all is long stuff (take ~260s for me to completely run celery-entrypoint.sh)
  3. Then, celery-beat and web
  4. And, the proxy to finish

This way all container starts well and prevent a lot of install issues.

Eg. It prevents migrations error like this
image

Fixed:

All my tests are passed.
Please test it a lot on Apple M1 😉

@0b3ud
Copy link

0b3ud commented May 2, 2024

I have tested this branch on a 64-bit ARM machine (aarch64/armv8) :

The machine was running Ubuntu 22.04 LTS 64-bit ARM

Results:

  • I was able to run the installation script and install properly 👍
  • Health checks passed 👍
  • I was able to do an application walkthrough with no visible errors 👍
  • I ran a test; The beginning of a scan against a locally hosted machine, and it ran with no visible errors 👍

The following section of this comment contains screenshots related to the results I got :

Health Checks :

image

Application interface (As I did the walkthrough) :

image

Some results after the beginning og a scanscan :

image

@psyray
Copy link
Author

psyray commented May 3, 2024

This one is good for me
Tested without the deps it works.

@0b3ud
Copy link

0b3ud commented May 6, 2024

I have conducted some installation trials on Raspberry Pi 4 :

This machine was running Rapsbian 64 bits version; Release Date : 2024-03-15

Results :

  • Unable to finish installation 👎
  • Installation fails with error message <<Container for service "celery"is unhealthy>> 👎

Despite changing the retries number from to 150 or even 200 in the docker_compose file, the Raspberry Pi seems uncapable of going throught celery's container installation and configuration


In the following section I share with you screenshots of behavior & results I encountered during my testings :

The Raspberry Pi's CPU was at 100% on all 4 cores through out the whole installation as shown in the screenshots bellow :

image

Exiting Error during the execution of install.sh :

image

Waiting on celery container :

image

@AnonymousWP AnonymousWP changed the title ops(docker): Arm64 support & improvement for smoother install/uninstall ops(docker): arm64 support & improvement for smoother install/uninstall May 15, 2024
@yarysp yarysp self-assigned this May 21, 2024
@yarysp yarysp added the bug Something isn't working label May 21, 2024
@yarysp
Copy link

yarysp commented May 21, 2024

According to the #69 bug and to make an install fail-proof, I will
I will close this PR and recreate one based on the modification provided
I will also split arm64 support and install/uninstall fix

@yarysp yarysp closed this May 21, 2024
@psyray psyray deleted the docker-arm64-support branch May 24, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add optional removal of images to uninstall.sh script
3 participants