Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image validator additions #671

Merged
merged 3 commits into from Mar 26, 2024
Merged

Image validator additions #671

merged 3 commits into from Mar 26, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

Additions to PR #670.

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • Adjustment of Build Workflow
    The setting in our project build process was tweaked to now include 'intl' and 'fileinfo' which are useful tools for handling internationalization and file data respectively.

  • Changelog Update
    Our change record now includes a new entry for the resolution of Issue Add Image validation rule #670 - the addition of an 'Image' validation rule. The 'Image' validation rule can verify image files according to specific criteria.

  • Updated Project Dependencies
    The project has been updated to use additional packages and modifications that aid in its operation. These include psr/http-message for handling HTTP messages in a standardized way; a suggestion for ext-fileinfo which is useful for handling and manipulating file information; and an upgrade to version 3.0 for yiisoft/translator package, a key tool in the application used for translations.

  • Addition of the 'Image' Rule
    We have integrated the new 'Image' rule into our application's rule set. This rule checks the validity of image files. This change is also reflected in our project documentation under the "File rules" section.

  • Enhancement of Test Mechanisms
    We have adjusted the way our application testing is conducted with the modification of method signatures in both RuleTestCase.php and CompareTest.php to ensure better and more accurate tests. New test image files were added to increase the range of tests for the new 'Image' rule.

  • Tests for New 'Image' Rule
    We've included a separate comprehensive set of tests specially dedicated to the new 'Image' rule to ensure its optimal functioning.

@arogachev arogachev self-assigned this Mar 26, 2024
@arogachev arogachev added the type:docs Documentation label Mar 26, 2024
@arogachev arogachev added this to the 1.3 milestone Mar 26, 2024
@arogachev arogachev changed the base branch from 1.x to image-validator March 26, 2024 08:51
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (48cbc71) to head (25fc87f).

Additional details and impacted files
@@                Coverage Diff                 @@
##             image-validator     #671   +/-   ##
==================================================
  Coverage              94.87%   94.87%           
  Complexity               818      818           
==================================================
  Files                     93       93           
  Lines                   2519     2519           
==================================================
  Hits                    2390     2390           
  Misses                   129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev marked this pull request as ready for review March 26, 2024 09:25
@arogachev arogachev requested review from a team and vjik March 26, 2024 09:26
@vjik vjik merged commit 1bb0ab9 into image-validator Mar 26, 2024
34 of 35 checks passed
@vjik vjik deleted the image-validator-additions branch March 26, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants