Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: extract root package configuration reader to separate class #172

Merged
merged 7 commits into from Mar 26, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 22, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

This is preparing to #146

Copy link

what-the-diff bot commented Mar 22, 2024

PR Summary

  • Refactoring of Root Package Configuration Reader
    The former root package configuration reader has been enhanced and migrated to an individual class, leading to an optimized and more manageable code structure.
  • Addition of src/Composer/RootConfiguration.php
    A new file named RootConfiguration.php is introduced in the src/Composer directory, contributing to the project's functionality.
  • Renaming Updated File
    The Options.php file in the src/Composer directory has been renamed to src/Composer/Options.php, making its purpose clearer.
  • Removal of Redundant Code
    Unused use statements in files like src/Composer/MergePlanProcess.php and src/Config.php have been removed. This action improves the cleanliness of the codebase, reduces any possible confusion, and enhances maintainability.
  • Refactoring Options-related Code in src/Composer/ProcessHelper.php
    To promote efficiency and readability, the options-related code in the src/Composer/ProcessHelper.php file has been refactored.
  • Addition of New Import types
    New import types have been included in multiple src and tests files, like src/Composer/ProcessHelper.php, src/Config.php, src/ConfigPaths.php, tests/Integration/IntegrationTestCase.php, and so on. These additions broaden the scope of what the project can achieve by importing new types from other modules or packages. They also improve code modularity and reusability.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (956eb22) to head (17b023b).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #172   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       277       283    +6     
===========================================
  Files             22        23    +1     
  Lines            725       738   +13     
===========================================
+ Hits             725       738   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team March 22, 2024 12:08
@vjik vjik added the status:code review The pull request needs review. label Mar 22, 2024
@vjik vjik merged commit 7a80d5e into master Mar 26, 2024
22 of 23 checks passed
@vjik vjik deleted the refactoring branch March 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants