Fix support for private git repos when using shorted repo syntax and lock file exists #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcanis is the best to review this. |
|
@bestander this night (Argentina time) I can add the tests (maybe I will need to move the get shrunk logic to a new method |
ramasilveyra
force-pushed
the
fix-private-deps
branch
4 times, most recently
from
3977ebd
to
6a0ccb9
Compare
…lock file exists Force git remote type if the resolved url it's a git private url.
ramasilveyra
force-pushed
the
fix-private-deps
branch
from
6a0ccb9
to
2293acf
Compare
|
Unit tests added! Solution change: issue fixed directly on the method |
|
Thanks, @ramasilveyra |
BYK
pushed a commit
that referenced
this pull request
Oct 26, 2017
**Summary** Yarn can not handle the `git+https://` dependency format correctly, as described for various versions in #1625. The problem is present in Yarn 1.2.1. A related problem for `git+ssh://` has been described in #573 and fixed in #3425. This PR extends the solution from #3425 to use the Git fetcher for any [Git-over-protocol](https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols) URLs. **Test plan** Extended the `package-request` unit tests to verify that the correct remote type (git) is used for `git+https://`, while the tarball remote type continues to be used for regular HTTP(S) URLs.
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…g#4759) **Summary** Yarn can not handle the `git+https://` dependency format correctly, as described for various versions in yarnpkg#1625. The problem is present in Yarn 1.2.1. A related problem for `git+ssh://` has been described in yarnpkg#573 and fixed in yarnpkg#3425. This PR extends the solution from yarnpkg#3425 to use the Git fetcher for any [Git-over-protocol](https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols) URLs. **Test plan** Extended the `package-request` unit tests to verify that the correct remote type (git) is used for `git+https://`, while the tarball remote type continues to be used for regular HTTP(S) URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2992 added support for private git repos when using shorted repo syntax (this landed on v0.24.0).
The generation for the first time of a
yarn.lockfile works well, but then with a yarn.lock file if you tryrm -rf node_modules && yarnfails with this error:error An unexpected error occurred: "Invalid protocol: git+ssh:".That error comes from https://github.com/request/request/blob/b12a6245d9acdb1e13c6486d427801e123fdafae/request.js#L455 and I think it's because yarn tries to use the tarball fetcher instead of the git fetcher.
The offline feature/fix added recently makes the git resolver defaults to the tarball to avoid http calls https://github.com/yarnpkg/yarn/pull/3000/files
Returning the git shrunk instead of the tarball if is possible seems to fix the issue.