Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [iOS] GestureRecognizers not working in iOS 13.4 #10162

Closed
dan5602 opened this issue Apr 1, 2020 · 125 comments · Fixed by xamarin/xamarin-macios#8264
Closed

[Bug] [iOS] GestureRecognizers not working in iOS 13.4 #10162

dan5602 opened this issue Apr 1, 2020 · 125 comments · Fixed by xamarin/xamarin-macios#8264
Labels
external-macios i/regression in-progress This issue has an associated pull request that may resolve it! iOS 13 p/iOS 🍎 t/bug 🐛

Comments

@dan5602
Copy link

dan5602 commented Apr 1, 2020

IMPORTANT UPDATE REGARDING THIS ISSUE. PLEASE READ BEFORE COMMENTING

⚠️ Please update to latest stable in Visual Studio for Mac (v8.5.2) and Windows (v16.5.3), we have released the update that includes the fix. Thanks again for your patience.


Description

After upgrading to xcode 11.4 and iOS 13.4 GestureRecognizers (TapGestureRecognizer) have stopped working on iOS. Android works as expected.

Steps to Reproduce

  1. Create a Xamarin Forms mobile application
  2. Add a label with a TapGestureRecognizer
  3. Try to invoke TapGestureRecognizer

Expected Behavior

TapGestureRecognizer is invoked

Actual Behavior

TapGestureRecognizer is not invoked

Basic Information

When updating MacOS to the below configuration, TapGestureRecognizer stops working in the iOS platform.

Configuration

Mac Catalina 10.15.4
VS2019 16.5.2
Xamarin VS package 13.6.0.11
Xamarin.Forms 4.5.0.495

Reproduction Link

Link

@dan5602 dan5602 added s/unverified New report that has yet to be verified t/bug 🐛 labels Apr 1, 2020
@pauldipietro pauldipietro added this to New in Triage Apr 1, 2020
@dan5602 dan5602 changed the title [iOS] GestureRecognizers not working in iOS 13.4 [Bug] [iOS] GestureRecognizers not working in iOS 13.4 Apr 1, 2020
@solomonfried
Copy link

solomonfried commented Apr 1, 2020

This may be associated to the issue I am seeing with Selections on CollectionView

[https://github.com//issues/10160]

This is critical. I guess I should not be to hasty in updating my Mac to the latest version. But now I am stuck and can't release my app due to Gesture Recognizers not working.
Hopefully a fix will be released soon.

@lhughey
Copy link

lhughey commented Apr 1, 2020

YES. This is a critical error that shouldn't have made it past UI smoke tests. All of my gesturerecognizers in iOS are broken, across multiple projects.

I'm also using
Mac Catalina 10.15.4
VS2019 16.5.2
Xamarin VS package 13.6.0.11
Xamarin.Forms 4.5.0.495
Xcode 11.4

@EvanMulawski
Copy link

May be due to this new delegate method on UIKit.UIGestureRecognizerDelegate:

gestureRecognizer:shouldReceiveEvent:

@chamons
Copy link

chamons commented Apr 1, 2020

Appears related to xamarin/xamarin-macios#8255 and @dalexsoto is running it down there.

dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this issue Apr 1, 2020
Fixes xamarin/Xamarin.Forms#10162
Fixes xamarin#8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.
@InquisitorJax
Copy link

Pretty easy to repro: just create a new Master Detail from the template, run the iOS app.
None of the items on the main page with navigate through to item detail because of the broken tapgesturerecognizer behavior.

@dan5602
Copy link
Author

dan5602 commented Apr 1, 2020

@InquisitorJax - Looks like the issue has been found and fixed already - well at least in macios

@samhouts samhouts added external-macios i/regression in-progress This issue has an associated pull request that may resolve it! and removed s/unverified New report that has yet to be verified labels Apr 1, 2020
@samhouts samhouts moved this from New to External in Triage Apr 1, 2020
@chamons
Copy link

chamons commented Apr 1, 2020

Fix is in PR, once we get a package we will validate. We believe we have this sucker pinned down.

@InquisitorJax
Copy link

@chamons that's great news - what does the release eta look like - I would imagine very many people who upgraded are now dead in the water because of this :(

monojenkins pushed a commit to monojenkins/xamarin-macios that referenced this issue Apr 1, 2020
Fixes xamarin/Xamarin.Forms#10162
Fixes xamarin#8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.
@rezamohamed
Copy link

I literally wasted so much time with the Mac OS upgrade and Visual Studio not syncing and now for the past day dealing with this thinking it was my code. Pretty frustrated with Xamarin right about now...I am just venting. Sorry!

@ezavil
Copy link

ezavil commented Apr 1, 2020

In a physical device with 13.3 OS it seems to work correctly, in the simulator with version 13.4 it fails...

monojenkins pushed a commit to monojenkins/xamarin-macios that referenced this issue Apr 1, 2020
Fixes xamarin/Xamarin.Forms#10162
Fixes xamarin#8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.
dalexsoto added a commit to xamarin/xamarin-macios that referenced this issue Apr 1, 2020
Fixes xamarin/Xamarin.Forms#10162
Fixes #8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.
dalexsoto added a commit to xamarin/xamarin-macios that referenced this issue Apr 1, 2020
Fixes xamarin/Xamarin.Forms#10162
Fixes #8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.

Co-authored-by: Alex Soto <alex@alexsoto.me>
@HopInTheCloud
Copy link

The update works. Thanks Xamarin Team

@dotMorten
Copy link
Contributor

dotMorten commented Apr 8, 2020

Can also confirm the reproducer I listed above now works, so the ArcGISRuntime Map controls are back in working order

@taublast
Copy link

taublast commented Apr 8, 2020

Lastest vs 2019 16.5.3 installed xam ios 13.16.0.13 but can't test as provisioning profiles and certificates are not received from mac anymore and are not listed in VS dropdowns on windows. Did not have this problem with previous VS version. I have xcode 11.4.
Is it by design and we have to setup all apple accounts on windows now? I have a feeling it checks only apple accounts on windows and shows nothing instead of syncing them from mac.. Created an apple account on Windows as a workaround.

OMG UPDATE this is by design: https://developercommunity.visualstudio.com/comments/962872/view.html

Even more <Image> stopped showing remote images on iOS with this update. SIlly replacing with ffimageloading <CachedImage> as a workaround.. I feel at times of forms 3 and below when was spending more time fighting framework bugs than creating an app.. Sigh

@InquisitorJax
Copy link

@taublast I think that's a separate issue. I had it with the 16.5.2 update, but this update worked fine. I had to provision new profiles to get it to work again.

@mshwf
Copy link

mshwf commented Apr 8, 2020

@taublast this happens with me a lot. And I have to restart Visual Studio /Mac/ Windows/ re-install the provisioning profiles.. , to get them back in Visual Studio. Sometimes they don't, and I have to build on Mac.

@myonlinegolfclub
Copy link

The update works. Thanks Xamarin Team

@CNBoland
Copy link

CNBoland commented Apr 8, 2020

TapGestureRecognizers are working in my app now as expected.

My setup:
Windows 10 Enterprise 1909
Visual Studio 2019 Professional 16.5.3
macOS Catalina 10.15.4
Xcode 11.4
Visual Studio for Mac Community 8.5.2
Mono Framework MDK 6.8.0.123
Xamarin.iOS 13.16.0.13
iOS (my device) 13.4

@Waaheeda
Copy link

Waaheeda commented Apr 8, 2020

facing same issue with my setup
Mac OS Version: 10.15.4 (19E266)
Visual Studio Version: VS 2019 Professional 8.5.1
Xamarin.iOS Version: 13.16.0.11
XCode Version: 11.4

@Waaheeda
Copy link

Waaheeda commented Apr 8, 2020

And update has fixed issue

thank you Xamarin Team for quick fix

@PureWeen
Copy link
Contributor

PureWeen commented Apr 9, 2020

#10162 (comment)

@PureWeen PureWeen closed this as completed Apr 9, 2020
Triage automation moved this from External to Closed Apr 9, 2020
@samhouts samhouts unpinned this issue Apr 20, 2020
@BRICEMARCELKOUADIO
Copy link

Can someone help me please, after the update my vs, it doesn't work yet!

@zerokewl88
Copy link

Can someone help me please, after the update my vs, it doesn't work yet!

Delete Obj / Bin Folders, clean, rebuild solution and try closing / opening VS.

What have you tried ?

@BRICEMARCELKOUADIO
Copy link

Can someone help me please, after the update my vs, it doesn't work yet!

Delete Obj / Bin Folders, clean, rebuild solution and try closing / opening VS.

What have you tried ?

it works now thanks

@zerokewl88
Copy link

Can someone help me please, after the update my vs, it doesn't work yet!

Delete Obj / Bin Folders, clean, rebuild solution and try closing / opening VS.
What have you tried ?

it works now thanks

For reference, and for others that find this thread, what did you do that resolved your problem ?

@BRICEMARCELKOUADIO
Copy link

Delete Obj / Bin Folders, clean, rebuild solution and try closing / opening VS.

I just do what you say here, thanks again

@odapplications
Copy link

Does not work on physical device. Strange how some tap gestures work on ios but not all. All work fine on android.

@odapplications
Copy link

Ios 13.3 it was not working when set in xaml. But in the .cs file it seems to be working. Using latest xamarin forms.

@wocar
Copy link

wocar commented May 23, 2020

It doesnt work for me, now with iOS 13.5.

I upgraded visual studio to the latest libraries and now works. ty

@LGFox
Copy link

LGFox commented Jun 23, 2020

TapGestureRecognizer doesn't work on iOS 13.5.1 again. And I publish this app to production. :-(
Updating VS to the latest 8.6.5 (build 23) fixes this issue.

@gcadmes
Copy link

gcadmes commented Jun 25, 2020

I'm not having any issues with TapGesture's on iOS 13.5.1

@andyfmking
Copy link

I'm having issues with multiple tap gesture recognizers on a grid on iOS 13.5

I have a recognizer for 1 tap, and a second recognizer for 2 taps, both on the same grid.

Only gesture recognizer with 1 tap fires on iOS while both gesture for 1 tap, and 2 taps fire on Android.

This means iOS fires only the first gesture with least number of taps and ignores all others.

Expected behavior is as on Android.
When tapped once, handler for 1 tap should fire and when tapped twice the handler for 2 taps should fire e.t.c

Tested on XF 4.6 and 4.7 on Visual studio Mac 8.6.5(build 23) and Microsoft Visual Studio 2019 Ver. 16.6.3

@OscarHMG
Copy link

I'm using TouchEffect, with panckeview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-macios i/regression in-progress This issue has an associated pull request that may resolve it! iOS 13 p/iOS 🍎 t/bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.