Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIKit] Fixes UIGestureRecognizer default introduced in iOS 13.4 #8261

Merged

Conversation

dalexsoto
Copy link
Member

fixes xamarin/Xamarin.Forms#10162
fixes #8255

Xcode 11.4 introduced a new protocol member to
UIGestureRecognizerDelegate and our initial proposed default value for
ShouldReceiveEvent is not playing well with the world.

Fixes xamarin/Xamarin.Forms#10162
Fixes xamarin#8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.
@dalexsoto dalexsoto added the note-highlight Worth calling out specifically in release notes label Apr 1, 2020
@dalexsoto dalexsoto added this to the xcode11.4 milestone Apr 1, 2020
Copy link
Contributor

@whitneyschmidt whitneyschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chamons
Copy link
Contributor

chamons commented Apr 1, 2020

In particular see:

xamarin/Xamarin.Forms#10162
#8255

@dalexsoto
Copy link
Member Author

@monojenkins backport d16-6

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 86 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

@dalexsoto
Copy link
Member Author

Known failure: HE0038

@dalexsoto
Copy link
Member Author

@monojenkins backport master

@dalexsoto dalexsoto merged commit b75deaf into xamarin:d16-5-xcode11.4 Apr 1, 2020
@dalexsoto dalexsoto deleted the d16-5-xcode11.4-uikitfix branch April 1, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix provided in #7882 results in issues on iOS Apps running on Simulators and on Devices
6 participants