Skip to content

Commit

Permalink
[UIKit] Fixes UIGestureRecognizer default introduced in iOS 13.4 (#8263)
Browse files Browse the repository at this point in the history
Fixes xamarin/Xamarin.Forms#10162
Fixes #8255

Xcode 11.4 introduced a new protocol member to
`UIGestureRecognizerDelegate` and our initial proposed default value for
`ShouldReceiveEvent` is not playing well with the world.

Co-authored-by: Alex Soto <alex@alexsoto.me>
  • Loading branch information
monojenkins and dalexsoto committed Apr 1, 2020
1 parent 5c8874b commit c6830ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/uikit.cs
Expand Up @@ -6113,7 +6113,7 @@ interface UIGestureRecognizerDelegate {
bool ShouldReceivePress (UIGestureRecognizer gestureRecognizer, UIPress press);

[TV (13,4), iOS (13,4)]
[Export ("gestureRecognizer:shouldReceiveEvent:"), DelegateName ("UIGesturesEvent"), DefaultValue (false)]
[Export ("gestureRecognizer:shouldReceiveEvent:"), DelegateName ("UIGesturesEvent"), DefaultValue (true)]
bool ShouldReceiveEvent (UIGestureRecognizer gestureRecognizer, UIEvent @event);
}

Expand Down

3 comments on commit c6830ca

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Experimental DDFun pipeline

🔥 Device tests completed (Failed) on iOS-DDFun on Azure DevOps(iOS-DDFun) 🔥

🔥 Tests failed catastrophically (no summary found)

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥

Test results

2 tests failed, 148 tests passed.

Failed tests

  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/Release: Failed

Please sign in to comment.