fix: Fixes an Interface field argument regression

[kidunot89]

What does this implement/fix? Explain your changes.

This fixes a regression to #3102 / #3100

Does this close any currently open issues?

closes: #3108

Any other comments?

Given the following code:

add_action( 'graphql_register_types', function() {

	register_graphql_interface_type( 'InterfaceWithArgs', [
		'fields' => [
			'fieldWithArgs' => [
				'type' => 'String',
				'args' => [
					'interfaceArg' => [
						'type' => 'String',
					],
				],
				'resolve' => function( $source, $args ) {
					return $args['arg'];
				}
			],
		]
	] );

	register_graphql_object_type( 'ObjectTypeImplementingInterfaceWithArgs', [
		'interfaces' => [ 'InterfaceWithArgs' ],
		'fields' => [
			'fieldWithArgs' => [
				'type' => 'String',
				'resolve' => function() {
					return 'object value';
				}
			],
		],
	] );

	register_graphql_field( 'RootQuery', 'interfaceArgsTest', [
		'type' => 'ObjectTypeImplementingInterfaceWithArgs',
		'resolve' => function() {
			return true;
		},
	]);

});

Before

The schema would be invalid:

And this query would be invalid:

After

The schema loads as valid and the test field can be queried

[codeclimate]

Avoid too many return statements within this method.

[codeclimate]

Function field_arg_type_to_string has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

[coveralls]

coverage: 84.343% (+0.02%) from 84.323%
when pulling dc959aa on kidunot89:fix/interface-field-arg-regression-fix
into 89ee7cf on wp-graphql:develop.

[justlevine]

@kidunot89 is this addressing something different than #3109 or is it just a different approach?

[jasonbahl]

@kidunot89 this breaks most of the workflows: https://github.com/wp-graphql/wp-graphql/pull/3112/checks

[kidunot89]

@jasonbahl @justlevine The breaking workflows are because of WPGraphQL TestCase. It should be resolved in the 3.0 release which I'm working on right now. I'll get it up and update the PR.

[justlevine]

@jasonbahl @justlevine The breaking workflows are because of WPGraphQL TestCase. It should be resolved in the 3.0 release which I'm working on right now. I'll get it up and update the PR.

Do we need update wp-graphql-test-case in a bugfix PR?

Also, I'm still unclear how this differs in approach (or purpose?) to #3109 .

I'm happy to give the same sort of code review (inline docs and reduced cyclomatic complexity), but it would be helpful to know what (if anything) I should be comparing.

[jasonbahl]

Do we need update wp-graphql-test-case in a bugfix PR?

@kidunot89 ya, I think we should handle any updates needed for WPGraphQL Test Case separately. Let's focus on the specific issue at hand here, a regression to the merging of Interface Fields with Object Type fields. The other changes are creating side effects that maybe should ultimately be handled, but not within this PR.

[codeclimate]

Function field_arg_type_to_string has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

[codeclimate]

Function field_arg_type_to_string has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

[jasonbahl]

@kidunot89 I added another test to cover complex arg types, such as:

	'args' => [
		'nonNullableArg' => [
			'type' => [ 'non_null' => 'String' ],
			'defaultValue' => 'nonNullableArg',
		],
		'listOfArg' => [
			'type' => [ 'list_of' => 'String' ],
			'defaultValue' => [ 'listOfArg', 'listOfArg 2' ],
		],
		'nonNullListOfString' => [
			'type' => [ 'non_null' => [ 'list_of' => 'String' ] ],
			'defaultValue' => [ 'nonNullListOfString', 'nonNullListOfString 2' ],
		],
		'listOfNonNullString' => [
			'type' => [ 'list_of' => [ 'non_null' => 'String' ] ],
			'defaultValue' => [ 'listOfNonNullString', 'listOfNonNullString 2' ],
		],
	],

[codeclimate]

Code Climate has analyzed commit dc959aa and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

[justlevine]

@jasonbahl I'm going to open up a follow up PR to add some code quality improvements and add the failure cases

[jasonbahl]

@jasonbahl I'm going to open up a follow up PR to add some code quality improvements and add the failure cases

@justlevine can you open the PR to the release branch and include updates to the changelogs as well?