fix: arguments on Interface Fields were not properly applied to interfaces and object types implementing the Interface

[jasonbahl]

What does this implement/fix? Explain your changes.

This fixes a regression to #3102 / #3100

• Failing Test: https://github.com/wp-graphql/wp-graphql/actions/runs/8852128733
• Passing Test: https://github.com/wp-graphql/wp-graphql/actions/runs/8852138235

Does this close any currently open issues?

closes: #3108

Any other comments?

Given the following code:

add_action( 'graphql_register_types', function() {

	register_graphql_interface_type( 'InterfaceWithArgs', [
		'fields' => [
			'fieldWithArgs' => [
				'type' => 'String',
				'args' => [
					'interfaceArg' => [
						'type' => 'String',
					],
				],
				'resolve' => function( $source, $args ) {
					return $args['arg'];
				}
			],
		]
	] );

	register_graphql_object_type( 'ObjectTypeImplementingInterfaceWithArgs', [
		'interfaces' => [ 'InterfaceWithArgs' ],
		'fields' => [
			'fieldWithArgs' => [
				'type' => 'String',
				'resolve' => function() {
					return 'object value';
				}
			],
		],
	] );

	register_graphql_field( 'RootQuery', 'interfaceArgsTest', [
		'type' => 'ObjectTypeImplementingInterfaceWithArgs',
		'resolve' => function() {
			return true;
		},
	]);

});

Before

The schema would be invalid:

And this query would be invalid:

After

The schema loads as valid and the test field can be queried

Where has this been tested?

Operating System: …

WordPress Version: …

[coveralls]

coverage: 84.291% (+0.002%) from 84.289%
when pulling 105a74c on jasonbahl:fix/3108-args-not-inherited-from-interface-fields
into a66f3e1 on wp-graphql:develop.

[codeclimate]

Code Climate has analyzed commit 105a74c and detected 0 issues on this pull request.

View more on Code Climate.

[justlevine]

Code lgtm.

With those description lines moved, could probably simplify the complexity by continueing early if ! isset( $interface_fields[ $field_name ]['type'] ). But that can also be addressed by adding a few inline comments.

Note: I'm not by my computer to check, but I've run into previous issues using unset() on the looping array and then checking isset() on the modified array, vaguely related to scoping. If we don't early return instead, I'd say this might benefit from another unit test to ensure that conditional doesn't pass when it shouldn't, but also probably not necessary.

[justlevine]

Code lgtm.

With those description lines moved, could probably simplify the complexity by continueing early if ! isset( $interface_fields[ $field_name ]['type'] ). But that can also be addressed by adding a few inline comments.

Note: I'm not by my computer to check, but I've run into previous issues using unset() on the looping array and then checking isset() on the modified array, vaguely related to scoping. If we don't early return instead, I'd say this might benefit from another unit test to ensure that conditional doesn't pass when it shouldn't, but also probably not necessary.

See jasonbahl#11 for an example of what I mean.

[jasonbahl]

closing in favor of #3112 which handles some additional cases not covered by this PR

Tests from this PR are handled in #3112:

• https://github.com/wp-graphql/wp-graphql/pull/3112/files#diff-b9b0ab687b2170fedfb7568ae8b1ae59ca53beec92447cba4fff22a2dbd25c09R457
• https://github.com/wp-graphql/wp-graphql/pull/3112/files#diff-b9b0ab687b2170fedfb7568ae8b1ae59ca53beec92447cba4fff22a2dbd25c09R546