Fix: Unknown media obeys settings.mediaLoadErrorHandling

[shezadkhan137]

No description provided.

[rafaeljusto]

This will probably solve issue #4525 .

Any plans on getting this merged? cc: @ashkulz

[romanodesouza]

👍 for this cc: @ashkulz

[jonathanbull]

Any update on this @ashkulz?

[ashkulz]

Sorry, I didn't notice this at all. Will review it by this weekend 🙈

[shezadkhan137]

@ashkulz Bump on this?

[mikesnare]

Bumping again. Hoping to get this merged in as we've hit it in our app as well. Our workaround is to try to detect this specific case by looking for an error code of 1 and detecting the 'ContentOperationNotPermittedError' string in stderr, but that's very hacky.

[jasperpg]

i'm thinking of doing the same as what mikesnare did. but there may be other legitimate conditions where the UnknownContentError or ContentOperationNotPermittedError or some other errors that may occur.

so, i hope this pr gets merged and a new release with the binaries released as well.

for now, i forked and applied the patch. but building it from source takes a very long time. in addition, i am only able to build it for my particular environment for now.

[alessionossa]

Any update?

[ashkulz]

Sorry for the late review! The problem is, the only way wkhtmltopdf can know it's a media request is by looking at the file extension -- but the PR as-is changes the non-media error handling, so is incorrect.

[shezadkhan137]

@ashkulz Thanks for the suggestion. I've updated the PR.