Patch to fix UnknownContentError #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- related ticket UE-1437
|
Pushing from the repo itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @PMPP / Owner,
This applies the patch described in here:
wkhtmltopdf/wkhtmltopdf#4461
Basically, there's an issue generating PDF when there are missing images in the html being rendered.
wkhtmltopdf/wkhtmltopdf#2187 (comment)
"QT webkit transforms this into UnknownContentError, presumably trying to interpret the html response body (the error message) as an image, despite code 400"
I rebuilt the binary from source.
Hope you can review and merge so we can resolve the issue.
Thanks!
P.S. also if possible do a release so we can reference from composer