Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Adding Roman numerals to page footer / header options #4065

Open
wants to merge 2 commits into
base: 0.12.1.x
Choose a base branch
from
Open

Adding Roman numerals to page footer / header options #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4e297
Adding Roman numerals to page footer / header options
andyepx Aug 30, 2018
baeb021
Adding Roman numerals to page footer / header options
andyepx Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/lib/outline.cc
View file
Open in desktop
Expand Up @@ -284,7 +284,24 @@ void OutlinePrivate::buildHFCache(OutlineItem * i, int level) {
buildHFCache(j, level+1);
}
}


QString Outline::numberToRoman(int number) {
// storing roman values of digits from 0-9
// when placed at different places
QString m[] = {"", "M", "MM", "MMM"};
QString c[] = {"", "C", "CC", "CCC", "CD", "D", "DC", "DCC", "DCCC", "CM"};
QString x[] = {"", "X", "XX", "XXX", "XL", "L", "LX", "LXX", "LXXX", "XC"};
QString i[] = {"", "I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX"};

// Converting to roman
QString thousands = m[number / 1000];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when the number of pages becomes more than 3000? Better to use repeated, see this untested code

QString thousands = QString("M").repeated(number / 1000)

QString hundereds = c[(number%1000) / 100];
QString tens = x[(number%100) / 10];
QString ones = i[number%10];

QString ans = thousands + hundereds + tens + ones;
return ans;
}

/*!
\brief Fill in header footer parameters for a given page
Expand Down Expand Up @@ -314,6 +331,15 @@ void Outline::fillHeaderFooterParms(int page, QHash<QString, QString> & parms, c
parms["frompage"] = QString::number(off+1);
parms["topage"] = QString::number(off+d->pageCount);
parms["page" ] = QString::number(page+off);

parms["frompage_roman"] = Outline::numberToRoman(off+1);
parms["topage_roman"] = Outline::numberToRoman(off+d->pageCount);
parms["page_roman" ] = Outline::numberToRoman(page+off);

parms["frompage_roman_lower"] = Outline::numberToRoman(off+1).toLower();
parms["topage_roman_lower"] = Outline::numberToRoman(off+d->pageCount).toLower();
parms["page_roman_lower" ] = Outline::numberToRoman(page+off).toLower();

parms["webpage"] = ps.page;
parms["section" ] = d->hfCache[0][page]?d->hfCache[0][page]->value:QString("");
parms["subsection" ] = d->hfCache[1][page]?d->hfCache[1][page]->value:QString("");
Expand Down
2 changes: 2 additions & 0 deletions src/lib/outline.hh
View file
Open in desktop
Expand Up @@ -39,6 +39,8 @@ public:
bool replaceWebPage(int d, const QString & name, QWebPrinter & wp, QWebFrame * f, const settings::PdfObject & ps, QVector<QPair<QWebElement, QString> > & local, QHash<QString, QWebElement> & anchors);
void addWebPage(const QString & name, QWebPrinter & wp, QWebFrame * frame, const settings::PdfObject & ps, QVector<QPair<QWebElement, QString> > & local, QHash<QString, QWebElement> & external);

QString Outline::numberToRoman(int number);

void fillHeaderFooterParms(int page, QHash<QString, QString> & parms, const settings::PdfObject & ps);
void fillAnchors(int d, QHash<QString, QWebElement> & anchors);
int pageCount();
Expand Down