This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Adding Roman numerals to page footer / header options #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashkulz
suggested changes
Apr 10, 2019
| QString i[] = {"", "I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX"}; | ||
|
|
||
| // Converting to roman | ||
| QString thousands = m[number / 1000]; |
There was a problem hiding this comment.
What happens when the number of pages becomes more than 3000? Better to use repeated, see this untested code
QString thousands = QString("M").repeated(number / 1000)
|
Thanks for the contribution, and sorry for the late review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to option to display page number as roman numerals, upper and lower case, to v12.1.1.x.
It would be really awesome if you consider including this in any future build, what's the process to submit pull requests / feature updates?
Thanks!