Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info to SSR page on using Astro.response #8011

Merged
merged 5 commits into from May 1, 2024
Merged

Add info to SSR page on using Astro.response #8011

merged 5 commits into from May 1, 2024

Conversation

ascorbic
Copy link
Contributor

Description (required)

The SSR docs currently have info on using Astro.request, but nothing about Astro.response. There is detail in the API guide, but I think it's helpful to have it on the SSR page too, so this PR adds it.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 1, 2024 2:55pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 25, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/server-side-rendering.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really well done, @ascorbic ! So easy to read and great examples. This is a real improvement to the page! 🙌

Just made one small suggestion to align with our pattern of explanations moving up ahead of the code block, instead of after.

The second code example is pretty small and I don't think it needs a similar sentence (as also supported by you not feeling the need to write one before.) But if we're going to have one for the first code block, let's do it before the sample, and give it some context! 🥳

src/content/docs/en/guides/server-side-rendering.mdx Outdated Show resolved Hide resolved
@ascorbic @sarah11918
Apply suggestions from code review
3ab7cea 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the helpful contribution!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 1, 2024
@sarah11918 sarah11918 merged commit e7a5c8a into withastro:main May 1, 2024
8 checks passed
@ascorbic ascorbic deleted the astro-response branch May 1, 2024 15:58
@jsparkdev jsparkdev mentioned this pull request May 2, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 2, 2024
@thomasbnt
i18n(fr): Update guides/server-side-rendering.mdx from withastro#8011
de8e3c8 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request May 2, 2024
Merged
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
@ascorbic @sarah11918 @wpplumber
Add info to SSR page on using Astro.response (withastro#8011)
58e8856 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
dreyfus92 added a commit that referenced this pull request May 4, 2024
@thomasbnt @dreyfus92
i18n(fr): Update guides/server-side-rendering.mdx from #8011 (#8156)
887c076 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@ascorbic @sarah11918 @wpplumber
Add info to SSR page on using Astro.response (withastro#8011)
a3d1b7c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update guides/server-side-rendering.mdx from withastro#8011…
5b39663 
… (withastro#8156)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascorbic @astrobot-houston @sarah11918