Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install on docker after 3.3.0/3.3.1 #1814

Closed
Kivol opened this issue Jun 22, 2020 · 23 comments
Closed

Cannot install on docker after 3.3.0/3.3.1 #1814

Kivol opened this issue Jun 22, 2020 · 23 comments

Comments

@Kivol
Copy link

Kivol commented Jun 22, 2020

npm ERR! path git
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm ERR! syscall spawn git
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/DABH/diagnostics.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Looks like this is related with #1813, and it still happens when trying to install on docker with nodejs 12.

@gbarrion4ccor
Copy link

Same problem here, but not only in docker. I can't npm install my project because of this dependency :

npm ERR! Error while executing:
npm ERR! /usr/local/bin/git ls-remote -h -t ssh://git@github.com/DABH/diagnostics.git
npm ERR! 
npm ERR! ssh: connect to host github.com port 22: Connection timed out
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

Wonder if the issue is it's trying to reach the dep over ssh instead of https.

Can one of you try modifying winston's package.json so that the diagnostics dep is
git+https://github.com/DABH/diagnostics.git
? That should force it to use https but I want to be 100% sure that solves your issue before doing another hotifx release. Thanks!

@jvandereijk
Copy link

jvandereijk commented Jun 22, 2020

I'm having the same issue when installing through docker.
I tried to modify the package.json, but I am not sure if I am doing it right.
in node_modules/winston/package.json I changed: "diagnostics": "github:DABH/diagnostics#master",
into: "diagnostics": "git+https://github.com/DABH/diagnostics.git",

This is not working, but I would have expected to need to change a dependency ending with "diagnostics.git" but I could not find that in the project.

edit: I am using 'node:12.10.0-alpine' as a base image for docker

@Kivol
Copy link
Author

Kivol commented Jun 22, 2020

I've been investigating about the issue and looks like the problem comes from alpine-based docker image. Even the following Dockerfile fails to build, regardless of node version.

FROM node:14-alpine

RUN npm install git+https://github.com/lodash/lodash

@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

Ah, because the dep is coming from github, you need git...

FROM node:14-alpine

RUN apk update && apk upgrade && \
    apk add --no-cache bash git openssh

RUN npm install git+https://github.com/lodash/lodash

I understand that's not a great solution. The alternative is I have to publish my diagnostics fork on NPM, but that package is already on NPM so I guess I'd need to change the name of my repo or something so I can publish uniquely. Any tips welcome else I'll look at this later today.

@Kivol
Copy link
Author

Kivol commented Jun 22, 2020

Yes I've come up with the same solution.(I couldn't even imagine that git isn't shipped on alpine..) I'm fine with that solution.

The problem was not with winston so I'm closing this. Thanks for the help!

@Kivol Kivol closed this as completed Jun 22, 2020
@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

Thanks, see my post above ^^

@PierreBrisorgueil
Copy link

PierreBrisorgueil commented Jun 22, 2020

@DABH @Kivol

hum, yep, I understand, Thx :)

For me the solution remains temporary and the issue should not be closed.

An NPM package should not require git for installation but only npm. If you use a FORK from another package because this one does not correspond to your need. I think this FORK must be integrated at the source or become a project maintained for Winston and therefore published as you suggested. It would be quite strange to impose the installation of git or any other tools for the installation of an npm package, for hundreds docker image. Images and process must be as lite as possible

@aeroxy
Copy link

aeroxy commented Jun 22, 2020

Hi, I just want to express that git shouldn't be a dep for winstonjs. Hope this can be resolved. We have a few hundreds of docker images and I don't think modifying all of them would be very ideal. And I am sure a lot of us would feel the same. :)

If 3.3.x really does have such breaking change, we should move it to 4.x instead.

@DABH @Kivol

@mbwhite
Copy link

mbwhite commented Jun 22, 2020

Second the comments above about this change being a breaking change. We have alpine docker images in production that will break due to this.

If this is required, then would support a 4.x change.

jt-nti added a commit to jt-nti/fabric-chaincode-node that referenced this issue Jun 22, 2020
Work around for issue winstonjs/winston#1814

Signed-off-by: James Taylor <jamest@uk.ibm.com>
@IdanAdar
Copy link

Wow, this one breaks the internet... :)
Very strange to require git indeed.

@lucianot54
Copy link

I have the same problem not in a docker image but in my enterprise network.

I use artifactory for download all dependencies (npm and github was blocked). If you use your fork, all projects without public access will fail. The biggest impact is for companies or CI/CD with restreint access.

For my point of view if you want keep your fork, you need to be standard and create a new package npm and not referer to a github repo.

@IdanAdar
Copy link

So why is this ticket still closed?

jt-nti added a commit to hyperledger/fabric-chaincode-node that referenced this issue Jun 22, 2020
Work around for issue winstonjs/winston#1814

Signed-off-by: James Taylor <jamest@uk.ibm.com>
@SamuelBrucksch
Copy link

Same problem here, please fix it. Unfortunately winston is installed as a module of a subdependency, so we can not directly modify the version. This breaks our CI pipeline that has no access to public github.

@mosheavni
Copy link

+1 for this issue, this breaks our CI pipeline.
Please revert the changes.

@mogadanez
Copy link

@Kivol please re-open, install git is not an option for many-many projects
especially when winston is not direct dependency.

@marikaner
Copy link
Contributor

marikaner commented Jun 22, 2020

+1 as well. This violates build once principle and breaks builds for our consumers. Maybe reverting until fixed is a good option here?

@mbwhite
Copy link

mbwhite commented Jun 22, 2020

Just to say that I think the comments above shows clearly how much Winston is used and depending on by many projects. So whilst it's a pain when issues occur - I hope I speak for many - when I say we do value the contribution Winston and it's developers make.

@bbailleux
Copy link

Same here.
Two points to add:

  1. adding dependencies to the CI/CD job based on an Alpine image breaks the concept and has a cost (think "green dev")
  2. in a corporate environment, we can not change the overall network (if ever we could!) configuration to get just one package

@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

Thanks for the active comments, please have patience for a couple hours as we try to roll out a better (non-git-dependent) solution for this.

@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

All, v3.3.2 has been released, this downloads the forked diagnostics dependency from NPM not GitHub so it should work for you. Please feel free to confirm or deny. Thanks!

@DABH DABH closed this as completed Jun 22, 2020
@georgejinu
Copy link

Thanks for the fix.

PierreBrisorgueil pushed a commit to weareopensource/Node that referenced this issue Jul 25, 2020
# 1.0.0 (2020-07-25)

### Bug Fixes

* **apis:** fix due to lou change 🐛 ([c32a484](c32a484))
* **apis:** fix duplicate save 🐛 ([6448b85](6448b85))
* **apis:** fix mapping / typing diff 🐛 ([dbcc06b](dbcc06b))
* **apis:** fix schema valid array 🐛 ([8a4cd99](8a4cd99))
* **apis:** quick fix on date 🐛 ([a53082f](a53082f))
* **auth:** message sign in 🐛 ([96f8435](96f8435))
* **config:** fix git ignore 🐛 ([3d2ab35](3d2ab35))
* **config:** fix mongoose settings 🐛 ([41263da](41263da))
* **config:** set no ssl by default (default = no certs) 🐛 ([4c798b0](4c798b0))
* **config:** update old config 🐛 ([72232a6](72232a6))
* **config,lib:** fix assets allJs files 🐛 ([452ee92](452ee92))
* **debug:** fixing gulp node debug task ([#1689](#1689)) ([531e3a1](531e3a1))
* **dependencies:** fix package lock 🐛 ([a3a35b6](a3a35b6))
* **dependencies:** fix package lock 🐛 ([f31d857](f31d857))
* **dependencies:** remove pm2 as default, responsible of 2 snyk 🐛 ([e682eee](e682eee))
* **dependencies:** tempo downgrade winston: winstonjs/winston#1814 🐛 ([41c35c6](41c35c6))
* **deps:** fix snyk version 🐛 ([ab68290](ab68290))
* **environment:** setting `test.js` environment for the sequlize orm to be `meantest` instead of `me ([bf3361e](bf3361e))
* **global:** count warning 🐛 ([e00f396](e00f396))
* **global:** default html send fixed 🐛 ([3a63aae](3a63aae))
* **global:** fix database configuration 🐛 ([e5413d6](e5413d6))
* **global:** fix knowledges style 👕 ([a72386d](a72386d))
* **global:** fix lint 🐛 ([79654a0](79654a0))
* **global:** purge useless file 🐛 ([d79ab55](d79ab55))
* **gulp:** fixing gulp-ava task usage which didnt return the stream which is why it didnt emit the ' ([3a36de1](3a36de1))
* **helpers:** align & review 🐛 ([42a68f3](42a68f3))
* **helpers:** fix $position of insert new data history 🐛 ([70a728c](70a728c))
* **helpers:** fix mails error catch ([07ebd21](07ebd21))
* **helpers, apis:** fix save 🐛 ([e036f67](e036f67))
* **jwt:** env variable name change for jwt secret ([ad651b9](ad651b9))
* **lib:** hot fix app init 🐛 ([7e6b36c](7e6b36c))
* **lib:** mongoose services mistake ... exhausted O.O 🐛 ([a5da7be](a5da7be))
* **lib:** show error if db initialization failed 🐛 ([f962a57](f962a57))
* **logger:** fix re-instantiation of winston loggers on method calls ([b6056fb](b6056fb))
* **mongoose:** fixing mongoose deprecation notice for promises library integration ([#1690](#1690)) ([008ec75](008ec75))
* **package:** tempos downgrade jest 🐛 ([e5f7085](e5f7085))
* **package:** update bcrypt to version 4.0.0 ([927d7c8](927d7c8))
* **package:** update chalk to version 3.0.0 ([54b4ac7](54b4ac7))
* **package:** update chalk to version 4.0.0 ([91ae908](91ae908))
* **package:** update cross-env to version 6.0.0 ([cc27101](cc27101))
* **package:** update cross-env to version 7.0.0 ([b7118b2](b7118b2))
* **package:** update generate-password to version 1.5.0 ([76cf130](76cf130))
* **package:** update google-auth-library to version 4.0.0 ([87e9744](87e9744))
* **package:** update google-auth-library to version 5.0.0 ([66fb57b](66fb57b))
* **package:** update google-auth-library to version 6.0.0 ([fede55b](fede55b))
* **package:** update helmet to version 3.16.0 ([3174d74](3174d74))
* **package:** update helmet to version 3.17.0 ([cc8c011](cc8c011))
* **package:** update helmet to version 3.18.0 ([1b06692](1b06692))
* **package:** update helmet to version 3.19.0 ([15afcdd](15afcdd))
* **package:** update helmet to version 3.20.0 ([b61747e](b61747e))
* **package:** update helmet to version 3.21.0 ([7eab8e4](7eab8e4))
* **package:** update idtoken-verifier to version 2.0.0 ([5353083](5353083))
* **package:** update mongoose to version 5.7.0 ([cc3929c](cc3929c))
* **package:** update mongoose to version 5.8.0 ([0b56522](0b56522))
* **package:** update mongoose to version 5.9.0 ([48e28aa](48e28aa))
* **package:** update nodemailer to version 6.4.0 ([beb9647](beb9647))
* **package:** update nodemon to version 2.0.0 ([1bd18aa](1bd18aa))
* **package:** update pm2 to version 4.0.0 ([428c559](428c559))
* **release:** url 🐛 ([c09c8c4](c09c8c4))
* **scripts:** add missing scripts 🐛 ([f175944](f175944))
* **scripts:** fix file name 🐛 ([4917832](4917832))
* **scripts:** fix scripts path 🐛 ([eef9078](eef9078))
* **tests:** try fix coveralls 🐛 ([5900177](5900177))
* **travis:** fix tests 🐛 ([2db3c58](2db3c58))
* **travis:** macosx travis services mongodb no longer available  🐛 ([fcabc8b](fcabc8b))
* **typing:** fix DATE_NEXT_DAY hours 🐛 ([52038b8](52038b8))
* **user:** fix optionnal 🐛 ([f76b66f](f76b66f))
* **users:** add uploads to data privacy mail 🐛 ([6e5d63b](6e5d63b))
* **users:** fix mail contact in templates 🐛 ([e49839a](e49839a))
* **users:** fix optionnal on /me 🐛 ([7675944](7675944))
* **users:** fix some comments 🐛 ([80e4b7d](80e4b7d))
* **users:** review schema & /me return 🐛 ([206902f](206902f))
* **users:** security review, filter user data return by default 🐛 ([af800d1](af800d1))
* .snyk to reduce vulnerabilities ([662e3ad](662e3ad))
* package.json & package-lock.json to reduce vulnerabilities ([709fac7](709fac7))
* package.json & package-lock.json to reduce vulnerabilities ([3319966](3319966))
* package.json & package-lock.json to reduce vulnerabilities ([dd135aa](dd135aa))
* **dependencies:** package.lock update 🐛 ([4e3442d](4e3442d))
* **global:** express warning 🐛 ([250b0af](250b0af))
* **package:** update mock-fs to version 4.8.0 ([ed1c772](ed1c772))
* **package:** update mongoose to version 5.6.0 ([f85ffc3](f85ffc3))
* **package:** update nodemailer to version 6.2.1 ([58b917a](58b917a))
* **package:** update nodemailer to version 6.3.0 ([4e92a66](4e92a66))
* **package:** update snyk to version 2.0.0 ([610b0d6](610b0d6))
* package.json & package-lock.json to reduce vulnerabilities ([b2016cf](b2016cf))
* **helpers:** fix error format 🐛 ([0e38c59](0e38c59))
* **package:** update joi-zxcvbn to version 5.0.0 ([b179907](b179907))
* **package:** update mongoose to version 5.5.0 ([c3dceee](c3dceee))
* **package:** update nodemailer to version 6.0.0 ([dd0558f](dd0558f))
* **package:** update nodemailer to version 6.1.0 ([4e58232](4e58232))
* **seed:** gulp task `test:seed` would hang on the gulp node process and not exit ([075e66c](075e66c))
* **sequelize:** fixing error handling in in sequelize lib instantiation ([02608a2](02608a2))
* **server:** fixing un-handled promise rejections when initaitlizing the app ([f73ec2b](f73ec2b))
* **tasks:** fixing tasks controller to use `req.user` as the storage of logged-in user details ([7430140](7430140))
* **tasks:** quick fix on model to authorize empty strings 🐛 ([fd0ddb8](fd0ddb8))
* **tasks:** quick fix TODO 🐛 ([8cf75ab](8cf75ab))
* **tests:** upgrade supertest to fix tests 🐛 ([5ba0624](5ba0624))
* **travis:** fix path and names 🐛 ([1ea863b](1ea863b))
* package.json & package-lock.json to reduce vulnerabilities ([a1adbe8](a1adbe8))
* **package:** update sequelize to version 5.1.0 ([8aa77db](8aa77db))
* **package:** update supertest to version 4.0.0 ([5de4f3f](5de4f3f))
* **tests:** refactoring tests to dismiss the supertest wrapper ([dc17715](dc17715))
* **users:** hide sensitive data from errors 🐛 ([2e07a90](2e07a90))
* **wiki:** links 📚 ([6101969](6101969))
* **yarn:** remove .lock, not updated by greenkeeper 🐛 ([6cc569b](6cc569b))
* .snyk to reduce vulnerabilities ([2ffe38a](2ffe38a))
* configure Snyk protect to enable patches ([9ca9600](9ca9600))
* package.json, package-lock.json & .snyk to reduce vulnerabilities ([935075d](935075d))

### Features

* **apis:** add autoRequest option ✨ ([761bdc7](761bdc7))
* **apis:** add cron & mail ✨ ([b58129e](b58129e))
* **apis:** add cron list request to services ✨ ([bae1c75](bae1c75))
* **apis:** add expiration & renew data if aggregate expired ✨ ([3086795](3086795))
* **apis:** add option to work without save ✨ ([ee88134](ee88134))
* **apis:** add path ✨ ([54e733c](54e733c))
* **apis:** add slug ✨ ([7ccb023](7ccb023))
* **apis:** add timestamp to data ✨ ([f4af8bd](f4af8bd))
* **apis:** add updated at date ✨ ([5468277](5468277))
* **apis:** add user dimension in history ✨ ([f3be4a2](f3be4a2)), closes [#3](#3)
* **apis:** auto detect merge key before save ✨ ([097056d](097056d))
* **apis:** clean code & add saving ✨ ([cea28f2](cea28f2))
* **apis:** clean some code ✨ ([632c538](632c538))
* **apis:** clean typing for meteo ✨ ([aef85b3](aef85b3))
* **apis:** first save ok ✨ ([a2676e3](a2676e3))
* **apis:** init aggregate ✨ ([1b19c03](1b19c03))
* **apis:** init get data road on api ✨ ([8d82a8e](8d82a8e))
* **apis:** init history ✨ ([683b33f](683b33f))
* **apis:** init mapping in apis ✨ ([c2eef4d](c2eef4d))
* **apis:** init module ✨ ([ec7edca](ec7edca))
* **apis:** init worker auto ✨ ([916597c](916597c))
* **apis:** limit data to 100 last ✨ ([a8307ef](a8307ef)), closes [#1](#1)
* **apis:** limit history size ✨ ([3a098e4](3a098e4))
* **apis:** new params settings ✨ ([c601325](c601325))
* **apis:** purge unset values during typing ✨ ([b84dea1](b84dea1))
* **apis:** review route and security ✨ ([4e6873d](4e6873d)), closes [#5](#5)
* **apis:** rework result ✨ ([6155968](6155968))
* **apis:** run worker auto if api auto request true ✨ ([43e46d1](43e46d1))
* **apis:** save in db for the first time :) ✨ ([787acf6](787acf6))
* **apis:** set api data request v0 ✨ ([b3c254a](b3c254a))
* **apis:** switch user for auto request ✨ ([1cc6901](1cc6901))
* **apis, helpers, config:** switch to service id, init request to lou ✨ ([6b3fad1](6b3fad1))
* **apis, historys:** set stats ✨ ([5ab49ea](5ab49ea))
* **apis, script:** set restore & purge db ✨ ([d530a4f](d530a4f))
* **auth:** add type & message for notification in sign in sign up ✨ ([4c7147d](4c7147d))
* **auth:** refactoring local user authentication strategy ([0689d0c](0689d0c))
* **ava:** initial project setup for ava test runner ([0f4da27](0f4da27))
* **commitizen): feat(commitizen:** introducing project support for commitizen ([f7acd13](f7acd13))
* **config:** add array management for systems var ✨ ([5e5ab52](5e5ab52))
* **config:** add config check and alert user if not ✨ ([0aeddbc](0aeddbc))
* **config:** add default cors ✨ ([77c3403](77c3403))
* **config:** change contact mail ✨ ([12b5532](12b5532))
* **config:** display cors at launch ✨ ([8758edc](8758edc))
* **config:** end mail config ✨ ([28fd56a](28fd56a))
* **config:** fix secret ✨ ([089ff7f](089ff7f))
* **config:** init montaine configuration ✨ ([3b8ffc7](3b8ffc7))
* **config:** rename config ✨ ([88d6934](88d6934))
* **config:** set restore exceptions ✨ ([bd6b6ec](bd6b6ec))
* **config:** upgrade ssl example ✨ ([cc0e4b5](cc0e4b5))
* **core:** add changelog releases routes ✨ ([57d9faf](57d9faf))
* **dependencies:** add inquirer for prompt message with gulp ✨ ([359bfa4](359bfa4))
* **dependencies:** add package lock ([10d4081](10d4081))
* **dependencies:** fix ✨ ([416b451](416b451))
* **dependencies:** package lock update ✨ ([1a409de](1a409de))
* **dependencies:** update all ✨ ([058e214](058e214))
* **dependencies:** upgrade all and switch tonew Joi ✨ ([ef5a50f](ef5a50f))
* **docker:** init docker & docker compose ✨ ([d28e047](d28e047))
* **docker:** review user to do nothing in root ✨ ([6ec0a82](6ec0a82))
* **error:** generic error handler for API requests ([f8274cb](f8274cb)), closes [#11](#11)
* **error:** generic error handler for API requests ([cd56b58](cd56b58))
* **gloabl:** init knowlegdges file like swift repo 🎉 ([96d2afa](96d2afa))
* **global:** add example api link in default html ✨ ([cc709f3](cc709f3))
* **global:** add fixme plugin for codeclimate 🎉 ([d9432a3](d9432a3))
* **global:** add keywords ✨ ([9d1935d](9d1935d))
* **global:** add mongo dump/restore (easy for dev team) ✨ ([2cffc39](2cffc39))
* **global:** add our own waos-CC to define and check commits ✨ ([a3ea1e1](a3ea1e1))
* **global:** add vue demo ✨ ([84ed54a](84ed54a))
* **global:** comitizen/comitlint & standard version initialization ([714c516](714c516))
* **global:** end update ✨ ([1ca9068](1ca9068))
* **global:** init wiki 📚 ([2181d33](2181d33))
* **global:** upgrade dependencies ⬆️ ([b9c616d](b9c616d))
* **global:** upgrade stack ✨ ([17e6134](17e6134))
* **global:** upgrade stack ✨ ([e8b629c](e8b629c))
* **helpers:** add return to response - allow next res operations ✨ ([06ba553](06ba553))
* **helpers:** add slug function to typing ✨ ([4639b57](4639b57))
* **helpers:** add some comments  💡 ([8f6f728](8f6f728))
* **helpers:** add typing map functions ✨ ([18a7d66](18a7d66))
* **helpers:** custom node error to deserve default api errors 🎉 ([0eab61d](0eab61d))
* **helpers:** init mail alert ✨ ([2fba2c8](2fba2c8))
* **helpers:** init mail alert template ✨ ([8918641](8918641))
* **history:** add get function ✨ ([6f1af80](6f1af80))
* **history:** add username ✨ ([0284a98](0284a98))
* **history:** init mail alert ✨ ([0da3fb4](0da3fb4))
* **history:** split from api :) ✨ ([eda9526](eda9526)), closes [#4](#4)
* **issues:** Update issue templates ([3e158e7](3e158e7))
* **jwt:** adding initial support for jwt authentication ([7b63c78](7b63c78))
* **jwt:** tidying up strategy definition ([3e2644f](3e2644f))
* **lib:** add graceful shutdown, prevention for docker ✨ ([eaa6a8e](eaa6a8e))
* **lib:** expose Joi function from middleware, for dynamic schema ✨ ([e6fac31](e6fac31))
* **middlewares:** add isOwner policy example ✨ ([09916ad](09916ad))
* **pacakge.json:** update engines and npm run scripts ([e7a8b9e](e7a8b9e))
* **readme:** add api informations 📚 ([c8cfc6d](c8cfc6d))
* **scraps:** add random date option ✨ ([5a12320](5a12320))
* **script:** end cron script ✨ ([d44cbaa](d44cbaa))
* **scripts:** add uploads in restore & switch to fs promise (big restore) ✨ ([71eb5d5](71eb5d5))
* **scripts:** adjust cron ✨ ([9d69274](9d69274))
* **scripts:** init cron ✨ ([de1c7a1](de1c7a1))
* **scripts:** init prod base db ✨ ([b8a89ed](b8a89ed))
* **seed:** add tasks in seed ✨ ([1b353b6](1b353b6))
* **seed:** adding seed support for sequelize and compiled both into a gulp task, also took out the ([ae3eaf3](ae3eaf3))
* **seed:** refactoring seeding functionality to be exported by the mongoose helper library and used as a gulp task, rather than the server bootstrap method ([27b4941](27b4941))
* **subscriptions:** init mail subscriptions example ✨ ([34fdd9c](34fdd9c))
* **tags:** reset ✨ ([235c725](235c725))
* **tasks:** add clean populate example ✨ ([dfaf37b](dfaf37b))
* **tasks:** init stats example ✨ ([e809d9a](e809d9a))
* **tasks:** new tasks module to use sequelizejs ([#1693](#1693)) ([3f9a872](3f9a872))
* **tasks,users:** add createAt updateAt ✨ ([d63699e](d63699e))
* **typing:** review hour conversion work ✨ ([03473c8](03473c8))
* **uploads:** add contentLength for direct download progress ✨ ([dea967a](dea967a))
* **uploads:** add purge script example ✨ ([363cd28](363cd28))
* **uploads:** add sharp operation example for images ✨ ([ad6461a](ad6461a))
* **uploads, config:** add sharp default configuration ✨ ([4f8faf1](4f8faf1))
* **user:** add bio ✨ ([fb31df8](fb31df8))
* **user:** add bio ✨ ([aab5668](aab5668))
* **user:** add test on register with same email ✅ ([a5bbec2](a5bbec2))
* **user:** add test on weak password ✅ ([fbd1e7f](fbd1e7f))
* **users:** add remove avatar ✨ ([f132fd9](f132fd9))
* **users:** add stats example ✨ ([e9108b2](e9108b2))
* **users:** add user delete option ✨ ([a0b75df](a0b75df))
* **users:** end policy ✨ ([4811602](4811602))
* **users:** rework tokens ✨ ([88a8191](88a8191))
* **users, tasks:** init data privacy management example ✨ ([58edcab](58edcab))
* **users, uploads, lib:** init uploadx example with gridfs & stream ✨ ([e991ecb](e991ecb))

### Reverts

* Revert ":shirt: fix lint" ([c5aec01](c5aec01))
PierreBrisorgueil pushed a commit to weareopensource/Node that referenced this issue Jul 25, 2020
# 1.0.0 (2020-07-25)

### Bug Fixes

* **auth:** message sign in 🐛 ([96f8435](96f8435))
* **config:** fix git ignore 🐛 ([3d2ab35](3d2ab35))
* **config:** fix mongoose settings 🐛 ([41263da](41263da))
* **config:** update old config 🐛 ([72232a6](72232a6))
* **dependencies:** fix package lock 🐛 ([a3a35b6](a3a35b6))
* **dependencies:** fix package lock 🐛 ([f31d857](f31d857))
* **dependencies:** remove pm2 as default, responsible of 2 snyk 🐛 ([e682eee](e682eee))
* **dependencies:** tempo downgrade winston: winstonjs/winston#1814 🐛 ([41c35c6](41c35c6))
* **deps:** fix snyk version 🐛 ([ab68290](ab68290))
* **global:** fix lint 🐛 ([79654a0](79654a0))
* **helpers:** fix mails error catch ([07ebd21](07ebd21))
* **lib:** hot fix app init 🐛 ([7e6b36c](7e6b36c))
* **lib:** mongoose services mistake ... exhausted O.O 🐛 ([a5da7be](a5da7be))
* **lib:** show error if db initialization failed 🐛 ([f962a57](f962a57))
* **package:** tempos downgrade jest 🐛 ([e5f7085](e5f7085))
* **package:** update bcrypt to version 4.0.0 ([927d7c8](927d7c8))
* **package:** update chalk to version 3.0.0 ([54b4ac7](54b4ac7))
* **package:** update chalk to version 4.0.0 ([91ae908](91ae908))
* **package:** update cross-env to version 6.0.0 ([cc27101](cc27101))
* **package:** update cross-env to version 7.0.0 ([b7118b2](b7118b2))
* **package:** update generate-password to version 1.5.0 ([76cf130](76cf130))
* **package:** update google-auth-library to version 6.0.0 ([fede55b](fede55b))
* **package:** update helmet to version 3.21.0 ([7eab8e4](7eab8e4))
* **package:** update idtoken-verifier to version 2.0.0 ([5353083](5353083))
* **package:** update mongoose to version 5.7.0 ([cc3929c](cc3929c))
* **package:** update mongoose to version 5.8.0 ([0b56522](0b56522))
* **package:** update mongoose to version 5.9.0 ([48e28aa](48e28aa))
* **package:** update nodemailer to version 6.4.0 ([beb9647](beb9647))
* **package:** update nodemon to version 2.0.0 ([1bd18aa](1bd18aa))
* **package:** update pm2 to version 4.0.0 ([428c559](428c559))
* **scripts:** add missing scripts 🐛 ([f175944](f175944))
* **scripts:** fix file name 🐛 ([4917832](4917832))
* **scripts:** fix scripts path 🐛 ([eef9078](eef9078))
* **tests:** try fix coveralls 🐛 ([5900177](5900177))
* **travis:** fix tests 🐛 ([2db3c58](2db3c58))
* **travis:** macosx travis services mongodb no longer available  🐛 ([fcabc8b](fcabc8b))
* **user:** fix optionnal 🐛 ([f76b66f](f76b66f))
* **users:** add uploads to data privacy mail 🐛 ([6e5d63b](6e5d63b))
* **users:** fix mail contact in templates 🐛 ([e49839a](e49839a))
* **users:** fix optionnal on /me 🐛 ([7675944](7675944))
* **users:** review schema & /me return 🐛 ([206902f](206902f))
* **users:** security review, filter user data return by default 🐛 ([af800d1](af800d1))
* .snyk to reduce vulnerabilities ([662e3ad](662e3ad))
* package.json & package-lock.json to reduce vulnerabilities ([709fac7](709fac7))
* package.json & package-lock.json to reduce vulnerabilities ([3319966](3319966))
* **users:** fix some comments 🐛 ([80e4b7d](80e4b7d))
* package.json & package-lock.json to reduce vulnerabilities ([dd135aa](dd135aa))
* package.json, package-lock.json & .snyk to reduce vulnerabilities ([935075d](935075d))
* **config:** set no ssl by default (default = no certs) 🐛 ([4c798b0](4c798b0))
* **config,lib:** fix assets allJs files 🐛 ([452ee92](452ee92))
* **debug:** fixing gulp node debug task ([#1689](#1689)) ([531e3a1](531e3a1))
* **dependencies:** package.lock update 🐛 ([4e3442d](4e3442d))
* **environment:** setting `test.js` environment for the sequlize orm to be `meantest` instead of `me ([bf3361e](bf3361e))
* **global:** default html send fixed 🐛 ([3a63aae](3a63aae))
* **global:** express warning 🐛 ([250b0af](250b0af))
* **global:** fix knowledges style 👕 ([a72386d](a72386d))
* **global:** purge useless file 🐛 ([d79ab55](d79ab55))
* **gulp:** fixing gulp-ava task usage which didnt return the stream which is why it didnt emit the ' ([3a36de1](3a36de1))
* **helpers:** fix error format 🐛 ([0e38c59](0e38c59))
* **jwt:** env variable name change for jwt secret ([ad651b9](ad651b9))
* **logger:** fix re-instantiation of winston loggers on method calls ([b6056fb](b6056fb))
* **mongoose:** fixing mongoose deprecation notice for promises library integration ([#1690](#1690)) ([008ec75](008ec75))
* **package:** update google-auth-library to version 4.0.0 ([87e9744](87e9744))
* **package:** update google-auth-library to version 5.0.0 ([66fb57b](66fb57b))
* **package:** update helmet to version 3.16.0 ([3174d74](3174d74))
* **package:** update helmet to version 3.17.0 ([cc8c011](cc8c011))
* **package:** update helmet to version 3.18.0 ([1b06692](1b06692))
* **package:** update helmet to version 3.19.0 ([15afcdd](15afcdd))
* **package:** update helmet to version 3.20.0 ([b61747e](b61747e))
* **package:** update joi-zxcvbn to version 5.0.0 ([b179907](b179907))
* **package:** update mock-fs to version 4.8.0 ([ed1c772](ed1c772))
* **package:** update mongoose to version 5.5.0 ([c3dceee](c3dceee))
* **package:** update mongoose to version 5.6.0 ([f85ffc3](f85ffc3))
* **package:** update nodemailer to version 6.0.0 ([dd0558f](dd0558f))
* **package:** update nodemailer to version 6.1.0 ([4e58232](4e58232))
* **package:** update nodemailer to version 6.3.0 ([4e92a66](4e92a66))
* **package:** update snyk to version 2.0.0 ([610b0d6](610b0d6))
* package.json & package-lock.json to reduce vulnerabilities ([b2016cf](b2016cf))
* **package:** update nodemailer to version 6.2.1 ([58b917a](58b917a))
* **package:** update sequelize to version 5.1.0 ([8aa77db](8aa77db))
* **package:** update supertest to version 4.0.0 ([5de4f3f](5de4f3f))
* **seed:** gulp task `test:seed` would hang on the gulp node process and not exit ([075e66c](075e66c))
* **sequelize:** fixing error handling in in sequelize lib instantiation ([02608a2](02608a2))
* **server:** fixing un-handled promise rejections when initaitlizing the app ([f73ec2b](f73ec2b))
* **tasks:** fixing tasks controller to use `req.user` as the storage of logged-in user details ([7430140](7430140))
* **tasks:** quick fix on model to authorize empty strings 🐛 ([fd0ddb8](fd0ddb8))
* **tasks:** quick fix TODO 🐛 ([8cf75ab](8cf75ab))
* **tests:** upgrade supertest to fix tests 🐛 ([5ba0624](5ba0624))
* **travis:** fix path and names 🐛 ([1ea863b](1ea863b))
* .snyk to reduce vulnerabilities ([2ffe38a](2ffe38a))
* configure Snyk protect to enable patches ([9ca9600](9ca9600))
* package.json & package-lock.json to reduce vulnerabilities ([a1adbe8](a1adbe8))
* **tests:** refactoring tests to dismiss the supertest wrapper ([dc17715](dc17715))
* **users:** hide sensitive data from errors 🐛 ([2e07a90](2e07a90))
* **wiki:** links 📚 ([6101969](6101969))
* **yarn:** remove .lock, not updated by greenkeeper 🐛 ([6cc569b](6cc569b))

### Features

* **auth:** add type & message for notification in sign in sign up ✨ ([4c7147d](4c7147d))
* **auth:** refactoring local user authentication strategy ([0689d0c](0689d0c))
* **ava:** initial project setup for ava test runner ([0f4da27](0f4da27))
* **commitizen): feat(commitizen:** introducing project support for commitizen ([f7acd13](f7acd13))
* **config:** add array management for systems var ✨ ([5e5ab52](5e5ab52))
* **config:** add config check and alert user if not ✨ ([0aeddbc](0aeddbc))
* **config:** add default cors ✨ ([77c3403](77c3403))
* **config:** display cors at launch ✨ ([8758edc](8758edc))
* **config:** upgrade ssl example ✨ ([cc0e4b5](cc0e4b5))
* **core:** add changelog releases routes ✨ ([57d9faf](57d9faf))
* **dependencies:** add inquirer for prompt message with gulp ✨ ([359bfa4](359bfa4))
* **dependencies:** update all ✨ ([058e214](058e214))
* **dependencies:** upgrade all and switch tonew Joi ✨ ([ef5a50f](ef5a50f))
* **docker:** init docker & docker compose ✨ ([d28e047](d28e047))
* **docker:** review user to do nothing in root ✨ ([6ec0a82](6ec0a82))
* **error:** generic error handler for API requests ([f8274cb](f8274cb)), closes [#11](#11)
* **error:** generic error handler for API requests ([cd56b58](cd56b58))
* **gloabl:** init knowlegdges file like swift repo 🎉 ([96d2afa](96d2afa))
* **global:** add example api link in default html ✨ ([cc709f3](cc709f3))
* **global:** add fixme plugin for codeclimate 🎉 ([d9432a3](d9432a3))
* **global:** add keywords ✨ ([9d1935d](9d1935d))
* **global:** add mongo dump/restore (easy for dev team) ✨ ([2cffc39](2cffc39))
* **global:** add our own waos-CC to define and check commits ✨ ([a3ea1e1](a3ea1e1))
* **global:** add vue demo ✨ ([84ed54a](84ed54a))
* **global:** comitizen/comitlint & standard version initialization ([714c516](714c516))
* **global:** init wiki 📚 ([2181d33](2181d33))
* **global:** upgrade dependencies ⬆️ ([b9c616d](b9c616d))
* **helpers:** add return to response - allow next res operations ✨ ([06ba553](06ba553))
* **helpers:** add some comments  💡 ([8f6f728](8f6f728))
* **helpers:** custom node error to deserve default api errors 🎉 ([0eab61d](0eab61d))
* **issues:** Update issue templates ([3e158e7](3e158e7))
* **jwt:** adding initial support for jwt authentication ([7b63c78](7b63c78))
* **jwt:** tidying up strategy definition ([3e2644f](3e2644f))
* **lib:** add graceful shutdown, prevention for docker ✨ ([eaa6a8e](eaa6a8e))
* **lib:** expose Joi function from middleware, for dynamic schema ✨ ([e6fac31](e6fac31))
* **middlewares:** add isOwner policy example ✨ ([09916ad](09916ad))
* **pacakge.json:** update engines and npm run scripts ([e7a8b9e](e7a8b9e))
* **readme:** add api informations 📚 ([c8cfc6d](c8cfc6d))
* **release:** semantic release ✨ ([54a96ae](54a96ae))
* **scripts:** add uploads in restore & switch to fs promise (big restore) ✨ ([71eb5d5](71eb5d5))
* **seed:** add tasks in seed ✨ ([1b353b6](1b353b6))
* **seed:** adding seed support for sequelize and compiled both into a gulp task, also took out the ([ae3eaf3](ae3eaf3))
* **seed:** refactoring seeding functionality to be exported by the mongoose helper library and used as a gulp task, rather than the server bootstrap method ([27b4941](27b4941))
* **subscriptions:** init mail subscriptions example ✨ ([34fdd9c](34fdd9c))
* **tasks:** add clean populate example ✨ ([dfaf37b](dfaf37b))
* **tasks:** init stats example ✨ ([e809d9a](e809d9a))
* **tasks:** new tasks module to use sequelizejs ([#1693](#1693)) ([3f9a872](3f9a872))
* **tasks,users:** add createAt updateAt ✨ ([d63699e](d63699e))
* **uploads:** add contentLength for direct download progress ✨ ([dea967a](dea967a))
* **uploads:** add purge script example ✨ ([363cd28](363cd28))
* **uploads:** add sharp operation example for images ✨ ([ad6461a](ad6461a))
* **uploads, config:** add sharp default configuration ✨ ([4f8faf1](4f8faf1))
* **user:** add bio ✨ ([fb31df8](fb31df8))
* **user:** add bio ✨ ([aab5668](aab5668))
* **user:** add test on register with same email ✅ ([a5bbec2](a5bbec2))
* **user:** add test on weak password ✅ ([fbd1e7f](fbd1e7f))
* **users:** add remove avatar ✨ ([f132fd9](f132fd9))
* **users:** add stats example ✨ ([e9108b2](e9108b2))
* **users:** add user delete option ✨ ([a0b75df](a0b75df))
* **users:** end policy ✨ ([4811602](4811602))
* **users:** rework tokens ✨ ([88a8191](88a8191))
* **users, tasks:** init data privacy management example ✨ ([58edcab](58edcab))
* **users, uploads, lib:** init uploadx example with gridfs & stream ✨ ([e991ecb](e991ecb))

### Reverts

* Revert ":shirt: fix lint" ([c5aec01](c5aec01))
PierreBrisorgueil pushed a commit to weareopensource/Node that referenced this issue Jul 25, 2020
# 1.0.0 (2020-07-25)

### Bug Fixes

* **auth:** message sign in 🐛 ([96f8435](96f8435))
* **config:** fix git ignore 🐛 ([3d2ab35](3d2ab35))
* **config:** fix mongoose settings 🐛 ([41263da](41263da))
* **config:** update old config 🐛 ([72232a6](72232a6))
* **dependencies:** fix package lock 🐛 ([a3a35b6](a3a35b6))
* **dependencies:** fix package lock 🐛 ([f31d857](f31d857))
* **dependencies:** remove pm2 as default, responsible of 2 snyk 🐛 ([e682eee](e682eee))
* **dependencies:** tempo downgrade winston: winstonjs/winston#1814 🐛 ([41c35c6](41c35c6))
* **deps:** fix snyk version 🐛 ([ab68290](ab68290))
* **global:** fix lint 🐛 ([79654a0](79654a0))
* **helpers:** fix mails error catch ([07ebd21](07ebd21))
* **lib:** hot fix app init 🐛 ([7e6b36c](7e6b36c))
* **lib:** mongoose services mistake ... exhausted O.O 🐛 ([a5da7be](a5da7be))
* **lib:** show error if db initialization failed 🐛 ([f962a57](f962a57))
* **package:** tempos downgrade jest 🐛 ([e5f7085](e5f7085))
* **package:** update bcrypt to version 4.0.0 ([927d7c8](927d7c8))
* **package:** update chalk to version 3.0.0 ([54b4ac7](54b4ac7))
* **package:** update chalk to version 4.0.0 ([91ae908](91ae908))
* **package:** update cross-env to version 6.0.0 ([cc27101](cc27101))
* **package:** update cross-env to version 7.0.0 ([b7118b2](b7118b2))
* **package:** update generate-password to version 1.5.0 ([76cf130](76cf130))
* **package:** update google-auth-library to version 6.0.0 ([fede55b](fede55b))
* **package:** update helmet to version 3.21.0 ([7eab8e4](7eab8e4))
* **package:** update idtoken-verifier to version 2.0.0 ([5353083](5353083))
* **package:** update mongoose to version 5.7.0 ([cc3929c](cc3929c))
* **package:** update mongoose to version 5.8.0 ([0b56522](0b56522))
* **package:** update mongoose to version 5.9.0 ([48e28aa](48e28aa))
* **package:** update nodemailer to version 6.4.0 ([beb9647](beb9647))
* **package:** update nodemon to version 2.0.0 ([1bd18aa](1bd18aa))
* **package:** update pm2 to version 4.0.0 ([428c559](428c559))
* **scripts:** add missing scripts 🐛 ([f175944](f175944))
* **scripts:** fix file name 🐛 ([4917832](4917832))
* **scripts:** fix scripts path 🐛 ([eef9078](eef9078))
* **tests:** try fix coveralls 🐛 ([5900177](5900177))
* **travis:** fix tests 🐛 ([2db3c58](2db3c58))
* **travis:** macosx travis services mongodb no longer available  🐛 ([fcabc8b](fcabc8b))
* **user:** fix optionnal 🐛 ([f76b66f](f76b66f))
* **users:** add uploads to data privacy mail 🐛 ([6e5d63b](6e5d63b))
* **users:** fix mail contact in templates 🐛 ([e49839a](e49839a))
* **users:** fix optionnal on /me 🐛 ([7675944](7675944))
* **users:** review schema & /me return 🐛 ([206902f](206902f))
* **users:** security review, filter user data return by default 🐛 ([af800d1](af800d1))
* .snyk to reduce vulnerabilities ([662e3ad](662e3ad))
* package.json & package-lock.json to reduce vulnerabilities ([709fac7](709fac7))
* package.json & package-lock.json to reduce vulnerabilities ([3319966](3319966))
* **users:** fix some comments 🐛 ([80e4b7d](80e4b7d))
* package.json & package-lock.json to reduce vulnerabilities ([dd135aa](dd135aa))
* package.json, package-lock.json & .snyk to reduce vulnerabilities ([935075d](935075d))
* **config:** set no ssl by default (default = no certs) 🐛 ([4c798b0](4c798b0))
* **config,lib:** fix assets allJs files 🐛 ([452ee92](452ee92))
* **debug:** fixing gulp node debug task ([#1689](#1689)) ([531e3a1](531e3a1))
* **dependencies:** package.lock update 🐛 ([4e3442d](4e3442d))
* **environment:** setting `test.js` environment for the sequlize orm to be `meantest` instead of `me ([bf3361e](bf3361e))
* **global:** default html send fixed 🐛 ([3a63aae](3a63aae))
* **global:** express warning 🐛 ([250b0af](250b0af))
* **global:** fix knowledges style 👕 ([a72386d](a72386d))
* **global:** purge useless file 🐛 ([d79ab55](d79ab55))
* **gulp:** fixing gulp-ava task usage which didnt return the stream which is why it didnt emit the ' ([3a36de1](3a36de1))
* **helpers:** fix error format 🐛 ([0e38c59](0e38c59))
* **jwt:** env variable name change for jwt secret ([ad651b9](ad651b9))
* **logger:** fix re-instantiation of winston loggers on method calls ([b6056fb](b6056fb))
* **mongoose:** fixing mongoose deprecation notice for promises library integration ([#1690](#1690)) ([008ec75](008ec75))
* **package:** update google-auth-library to version 4.0.0 ([87e9744](87e9744))
* **package:** update google-auth-library to version 5.0.0 ([66fb57b](66fb57b))
* **package:** update helmet to version 3.16.0 ([3174d74](3174d74))
* **package:** update helmet to version 3.17.0 ([cc8c011](cc8c011))
* **package:** update helmet to version 3.18.0 ([1b06692](1b06692))
* **package:** update helmet to version 3.19.0 ([15afcdd](15afcdd))
* **package:** update helmet to version 3.20.0 ([b61747e](b61747e))
* **package:** update joi-zxcvbn to version 5.0.0 ([b179907](b179907))
* **package:** update mock-fs to version 4.8.0 ([ed1c772](ed1c772))
* **package:** update mongoose to version 5.5.0 ([c3dceee](c3dceee))
* **package:** update mongoose to version 5.6.0 ([f85ffc3](f85ffc3))
* **package:** update nodemailer to version 6.0.0 ([dd0558f](dd0558f))
* **package:** update nodemailer to version 6.1.0 ([4e58232](4e58232))
* **package:** update nodemailer to version 6.3.0 ([4e92a66](4e92a66))
* **package:** update snyk to version 2.0.0 ([610b0d6](610b0d6))
* package.json & package-lock.json to reduce vulnerabilities ([b2016cf](b2016cf))
* **package:** update nodemailer to version 6.2.1 ([58b917a](58b917a))
* **package:** update sequelize to version 5.1.0 ([8aa77db](8aa77db))
* **package:** update supertest to version 4.0.0 ([5de4f3f](5de4f3f))
* **seed:** gulp task `test:seed` would hang on the gulp node process and not exit ([075e66c](075e66c))
* **sequelize:** fixing error handling in in sequelize lib instantiation ([02608a2](02608a2))
* **server:** fixing un-handled promise rejections when initaitlizing the app ([f73ec2b](f73ec2b))
* **tasks:** fixing tasks controller to use `req.user` as the storage of logged-in user details ([7430140](7430140))
* **tasks:** quick fix on model to authorize empty strings 🐛 ([fd0ddb8](fd0ddb8))
* **tasks:** quick fix TODO 🐛 ([8cf75ab](8cf75ab))
* **tests:** upgrade supertest to fix tests 🐛 ([5ba0624](5ba0624))
* **travis:** fix path and names 🐛 ([1ea863b](1ea863b))
* .snyk to reduce vulnerabilities ([2ffe38a](2ffe38a))
* configure Snyk protect to enable patches ([9ca9600](9ca9600))
* package.json & package-lock.json to reduce vulnerabilities ([a1adbe8](a1adbe8))
* **tests:** refactoring tests to dismiss the supertest wrapper ([dc17715](dc17715))
* **users:** hide sensitive data from errors 🐛 ([2e07a90](2e07a90))
* **wiki:** links 📚 ([6101969](6101969))
* **yarn:** remove .lock, not updated by greenkeeper 🐛 ([6cc569b](6cc569b))

### Features

* **auth:** add type & message for notification in sign in sign up ✨ ([4c7147d](4c7147d))
* **auth:** refactoring local user authentication strategy ([0689d0c](0689d0c))
* **ava:** initial project setup for ava test runner ([0f4da27](0f4da27))
* **commitizen): feat(commitizen:** introducing project support for commitizen ([f7acd13](f7acd13))
* **config:** add array management for systems var ✨ ([5e5ab52](5e5ab52))
* **config:** add config check and alert user if not ✨ ([0aeddbc](0aeddbc))
* **config:** add default cors ✨ ([77c3403](77c3403))
* **config:** display cors at launch ✨ ([8758edc](8758edc))
* **config:** upgrade ssl example ✨ ([cc0e4b5](cc0e4b5))
* **core:** add changelog releases routes ✨ ([57d9faf](57d9faf))
* **dependencies:** add inquirer for prompt message with gulp ✨ ([359bfa4](359bfa4))
* **dependencies:** update all ✨ ([058e214](058e214))
* **dependencies:** upgrade all and switch tonew Joi ✨ ([ef5a50f](ef5a50f))
* **docker:** init docker & docker compose ✨ ([d28e047](d28e047))
* **docker:** review user to do nothing in root ✨ ([6ec0a82](6ec0a82))
* **error:** generic error handler for API requests ([f8274cb](f8274cb)), closes [#11](#11)
* **error:** generic error handler for API requests ([cd56b58](cd56b58))
* **gloabl:** init knowlegdges file like swift repo 🎉 ([96d2afa](96d2afa))
* **global:** add example api link in default html ✨ ([cc709f3](cc709f3))
* **global:** add fixme plugin for codeclimate 🎉 ([d9432a3](d9432a3))
* **global:** add keywords ✨ ([9d1935d](9d1935d))
* **global:** add mongo dump/restore (easy for dev team) ✨ ([2cffc39](2cffc39))
* **global:** add our own waos-CC to define and check commits ✨ ([a3ea1e1](a3ea1e1))
* **global:** add vue demo ✨ ([84ed54a](84ed54a))
* **global:** comitizen/comitlint & standard version initialization ([714c516](714c516))
* **global:** init wiki 📚 ([2181d33](2181d33))
* **global:** upgrade dependencies ⬆️ ([b9c616d](b9c616d))
* **helpers:** add return to response - allow next res operations ✨ ([06ba553](06ba553))
* **helpers:** add some comments  💡 ([8f6f728](8f6f728))
* **helpers:** custom node error to deserve default api errors 🎉 ([0eab61d](0eab61d))
* **issues:** Update issue templates ([3e158e7](3e158e7))
* **jwt:** adding initial support for jwt authentication ([7b63c78](7b63c78))
* **jwt:** tidying up strategy definition ([3e2644f](3e2644f))
* **lib:** add graceful shutdown, prevention for docker ✨ ([eaa6a8e](eaa6a8e))
* **lib:** expose Joi function from middleware, for dynamic schema ✨ ([e6fac31](e6fac31))
* **middlewares:** add isOwner policy example ✨ ([09916ad](09916ad))
* **pacakge.json:** update engines and npm run scripts ([e7a8b9e](e7a8b9e))
* **readme:** add api informations 📚 ([c8cfc6d](c8cfc6d))
* **release:** semantic release ✨ ([54a96ae](54a96ae))
* **scripts:** add uploads in restore & switch to fs promise (big restore) ✨ ([71eb5d5](71eb5d5))
* **seed:** add tasks in seed ✨ ([1b353b6](1b353b6))
* **seed:** adding seed support for sequelize and compiled both into a gulp task, also took out the ([ae3eaf3](ae3eaf3))
* **seed:** refactoring seeding functionality to be exported by the mongoose helper library and used as a gulp task, rather than the server bootstrap method ([27b4941](27b4941))
* **subscriptions:** init mail subscriptions example ✨ ([34fdd9c](34fdd9c))
* **tasks:** add clean populate example ✨ ([dfaf37b](dfaf37b))
* **tasks:** init stats example ✨ ([e809d9a](e809d9a))
* **tasks:** new tasks module to use sequelizejs ([#1693](#1693)) ([3f9a872](3f9a872))
* **tasks,users:** add createAt updateAt ✨ ([d63699e](d63699e))
* **uploads:** add contentLength for direct download progress ✨ ([dea967a](dea967a))
* **uploads:** add purge script example ✨ ([363cd28](363cd28))
* **uploads:** add sharp operation example for images ✨ ([ad6461a](ad6461a))
* **uploads, config:** add sharp default configuration ✨ ([4f8faf1](4f8faf1))
* **user:** add bio ✨ ([fb31df8](fb31df8))
* **user:** add bio ✨ ([aab5668](aab5668))
* **user:** add test on register with same email ✅ ([a5bbec2](a5bbec2))
* **user:** add test on weak password ✅ ([fbd1e7f](fbd1e7f))
* **users:** add remove avatar ✨ ([f132fd9](f132fd9))
* **users:** add stats example ✨ ([e9108b2](e9108b2))
* **users:** add user delete option ✨ ([a0b75df](a0b75df))
* **users:** end policy ✨ ([4811602](4811602))
* **users:** rework tokens ✨ ([88a8191](88a8191))
* **users, tasks:** init data privacy management example ✨ ([58edcab](58edcab))
* **users, uploads, lib:** init uploadx example with gridfs & stream ✨ ([e991ecb](e991ecb))

### Reverts

* Revert ":shirt: fix lint" ([c5aec01](c5aec01))
mbwhite added a commit to hyperledger/fabric-chaincode-node that referenced this issue Nov 10, 2020
* [FABCI-482] Update Nexus URL's to Artifactory

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>

* [FABCN-377] Prepare v2.0 release

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Fix docker tag

Tag needs to include hyperledger to match the publish command

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-377] Bump version to 2.0.1

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-378] Publish jsdoc

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Re-enable tests

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-381] Access localmspid

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Update audit level

Temporarily raise audit level to moderate to work around current minimist audit failures

Can be reverted after grpc, rc, and tar dependecies have been updated to pull in updated versions of mkdirp and minimist

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Expand node engine version range

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* FABCN-391 Use version 2.1 of fabric docker images

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* FABCN-391 Update test/chaincodes to use node 10 and add a missing hat

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* [FABCN-377] Prepare for v2.1 unstable builds (WIP)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-373] Compatibility Matrix

Ammended all the node-engines in package.json to match
that in the docker image

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Change-Id: Ia536ed66daf857679adf9f858b35d206a4f1007f

* [FABCN-382] fix compatibility.md title

Signed-off-by: Andrew Hurt <andrew.hurt1@ibm.com>

* Improve build reliability

It looks like rushjs symlinking can cause issues with the CopyFiles task. Use a script instead as suggested in microsoft/azure-pipelines-tasks#9046

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Add readme to redirect to site

Signed-off-by: Ry Jones <ry@linux.com>

* FABCN-241 Remove to.be.ok

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* FABCN-241  Change to.be.ok

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* FABCN-241 Remove to.be.ok

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* fix: remove semicolon

Signed-off-by: Johnny Da Costa <johnny.dacosta@he-arc.ch>

* FABCN-391 Set docker images to use node 10
- reflect this in compatibility.md
- update some out of date tutorial lines

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* FABCN-391 Build against release-2.x

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* FABCN-391 Remove references to 2.0 and 2.0.0
- replace with 2.x

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* [FABCN-392] Update to Node 12

Set node engine to be the latest LTS at time of commit 12.6.1
Due to issues with comibation of the 12.6 and rewire, unit tests are run
with node 12.5.0

Updated timeout as Typescript compilation seems to have slowed down.

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* [FABCN-391] Publish JSDoc to release-2.1

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* FABCN-391 v2.1.0 Release (#112)

* FABCN-391 v2.1.0 Release
- also fixed nodeenv images to use node 12

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* Update timeout (#114)

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>

Co-authored-by: Brett Logan <brett.t.logan@ibm.com>

* FABCN-391 Bump to 2.1.1 and fix docker tag (#122)

* FABCN-391 Remove "latest" from tag name on docker image publishing for tagged versions

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* FABCN-391 Bump version number to 2.1.1

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* [FABCN-391] fix directory for api doc publish (#125)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-394] Update typescript interface file (#128)

Updated both typescript definition files to match the case
and the existance of the implementation function.

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Prepare 2.1.1 release (#133)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Bump version (#134)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-397] State queries limited to 100 results (#141)

Errow was the new version of protobufjs used to create the bundle.js
gave a different property to the 'has more' field.  hasMore replaced
has_more

As this accessed as JS property it didn't fail, but meant only a limited
number could be accessed.

corrected, added test for 229 results.
bit of dead code pruning

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* [FABCN-396] Add notes on minimum 1.4 module version for node 12 (#139)

Stated that 1.4.5 and above are the versions that work with node 12
Added a better example for the use of the chaincode node runtime environment
variable

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* FABCN-395: Use @grpc/grpc-js for Node.js chaincode (#143) (#144)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>

* FABCN-401 Correct use of Yargs api (#145)

* FABCN-401 Correct use of Yargs api

Change from package.json to api parser configuration

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Force build

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Fix broken tutorials link (#137) (#138)

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>

Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Prepare 2.1.2 release (#148)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Bump version to 2.1.3 (#149)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* FABCN-405 Fix tutorial reference (#150) (#152)

Updated to use 2.1 modules

Signed-off-by: Ry Jones <ry@linux.com>

Co-authored-by: Matthew B White <mbwhite@users.noreply.github.com>
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

Co-authored-by: Ry Jones <ry@linux.com>

* [FABCN-407] Update protos (#154) (#157)

To prepare for the implementation of chaincode gRPC server, this patch
updates protobuf definitions to the latest ones.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-410] Use new lifecycle for fv/e2e tests (#160)

This patch enables v2.0 feature in the test Hyperledger Fabric network
and uses new lifecycle commands in the fv and e2e tests.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* Fix 'rush install' error in release-2.x (#163)

This patch upgrades pnpm to fix the "Could not find peer dependency
'google-auth-library'" error.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* Cheery-pick chaincode server feature to release-2.x (#166)

* [FABCN-408] Separate message handler from client (#155)

This patch divides the ChaincodeSupportClient class into two classes:
ChaincodeSupportClient, which represents a chaincode client that
connects to a peer, and ChaincodeMessageHandler, which handles messages
in communciation with the peer through a stream.

Because the latter part is common in both client and server model,
the ChaincodeMessageHandler class will be used in the future
implementation for a chaincode gRPC server.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

Co-authored-by: Matthew B White <mbwhite@users.noreply.github.com>

* [FABCN-409] Chaincode gRPC server w/o TLS (#159)

This patch adds the ChaincodeServer class to support the server mode of
chaincode.
It also adds the server() method, which creates a new instance of
the ChaincodeServer class, to the Shim class, the entrypoint of the
fabric-shim library.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-411] Add server command to CLI (#161)

This patch adds a "server" command to the "fabric-chaincode-node" CLI.
The command starts the contracts as a chaincode server.

Example: fabric-chaincode-node server --chaincode-address 0.0.0.0:9999 \
           --chaincode-id mycc_v0:a1233bb13227a05932

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-413] Add e2e test for chaincode server (#162)

This patch adds new e2e test for the chaincode gRPC server feature.

The test performs as following:
  - Create a package which contains server and cc information
  - Build a container image of the chaincode
  - Install the package into peers
  - Obtain the installed package ID from the peers
  - Start the chaincode container with the package ID
  - Approve and commit the chaincode definition
  - Invoke and query the chaincode

"rush test:e2e" will perform both tests for both server and client mode.

This patch also modifies "rush start-fabric" to use external builder
scripts.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-414] Update TypeScript definition (#165)

This patch updates the type defintion file for TypeScript to add classes
and interfaces related to the chaincode server feature.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-412] TLS support for chaincode server (#164)

This patch adds TLS support for chaincode server.

To enable TLS, set tlsProps in the second argument for shim.server,
or add --chaincode-tls-cert-file and --chaincode-tls.key-file for CLI.

Client certificate validation can be enabled via tlsProps.clientCACerts
for shim.server or --chaincode-tls-client-cacert-file for CLI.

Also the -path options (for base64 encoded files) are supported.

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

Co-authored-by: Matthew B White <mbwhite@users.noreply.github.com>

* [FABCN-415] Lock grpc-js to 1.0.3 (#170)

@grpc/grpc-js updated to 1.1.0; this has caused the initial request to the
peer on chaincode start to fail.

Dropping back to 1.0.3 resolves the issue.

See FABCN-415

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* [FABCN-416] Release v2.1.3 (#171)

For resolving grpc version dependency

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Specify exact version of winston dependency

Work around for issue winstonjs/winston#1814

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Prepare 2.1.4 release (#174)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-393] Fix broken links in documents (#169)

This patch fixes broken links to the fabric documents.
This patch also fixes links to point to those for the proper version
(2.1).

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* Bump version to 2.1.5 (#175)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-319] Update dependnency versions (#176)

- Update grpc-js and winston to pre-lock levels
- General update of dependcies
- Note add about shirnkwrap.
- Corrected test cases

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* [FABCN-420] Remove Azure pipeline warnings (#177)

Used new coverage merge tool to joing coverage together

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Use Official CouchDB 3.1 Image (#180)

Fabric 2.2 removes official support for CouchDB 2.x.
The migration to 3.1 was to address fsync issues
in the underlying storage implementation in Couch.

This change moves to CouchDB 3.1 which requires the
user to now set an admin identity at startup.

Node 12.18.2 is the latest LTS

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>

* [FABCN-421] release: 2.2.0 LTS release (#181)

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* Bump version to 2.2.1 (#184)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Fix: ChaincodeStub.getMspID should be in lowerCamelCASE

Signed-off-by: winderica <winderica@gmail.com>

* [FABCN-422] Add release guide (#187)

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* [FABCN-433] Update typescript and @types/node (#199)

Need current supported levels.

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* [FABCN-241] Remove to.be.ok (#204)

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* [FABCN-435] OOM on Large Arg Size (#207)

Incorrect trace point logging entire binary message

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>

* v2.x tutorials updated (#217)

Signed-off-by: Kestutis Gudynas <44440041+kemi04@users.noreply.github.com>

* [FABCN-430] Fix type for timestamp.second (#194) (#209)

This patch fixes the type definition for the second field in the
Timestamp, which is actually Long (int64).

Signed-off-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

Co-authored-by: Matthew B White <mbwhite@users.noreply.github.com>

Co-authored-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>

* [FABCN-432] - Update class transformer dependency (#213)

* [FABCN-241] Remove to.be.ok

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* [FABCN-1627]-Update class transformer dependency

Signed-off-by: lesleyannj <lesleyannj@hotmail.com>

* Release v2.3.0

Signed-off-by: Kestutis Gudynas <gudynask@gmail.com>

* Bump version to 2.3.1

Signed-off-by: Kestutis Gudynas <gudynask@gmail.com>

Co-authored-by: Brett Logan <brett.t.logan@ibm.com>
Co-authored-by: heatherlp <heatherpollard0@gmail.com>
Co-authored-by: Matthew B White <whitemat@uk.ibm.com>
Co-authored-by: Andrew Hurt <andrew.hurt1@ibm.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: lesleyannj <lesleyannj@hotmail.com>
Co-authored-by: Johnny Da Costa <johnny.dacosta@he-arc.ch>
Co-authored-by: Matthew B White <mbwhite@users.noreply.github.com>
Co-authored-by: heatherlp <40789053+heatherlp@users.noreply.github.com>
Co-authored-by: Simon Stone <sstone1@uk.ibm.com>
Co-authored-by: nikhil550 <nikhilg550@gmail.com>
Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>
Co-authored-by: Taku Shimosawa <taku.shimosawa@hal.hitachi.com>
Co-authored-by: winderica <winderica@gmail.com>
Co-authored-by: LAJ <33546098+lesleyannjordan@users.noreply.github.com>
Co-authored-by: Kestutis Gudynas <44440041+kemi04@users.noreply.github.com>
Co-authored-by: Kestutis Gudynas <gudynask@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests