Skip to content

Commit

Permalink
Specify exact version of winston dependency
Browse files Browse the repository at this point in the history 
Work around for issue winstonjs/winston#1814

Signed-off-by: James Taylor <jamest@uk.ibm.com>
  • Loading branch information
@jt-nti
jt-nti committed Jun 22, 2020
1 parent e3595af commit 81e1123
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion apis/fabric-contract-api/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"fast-safe-stringify": "~2.0.7",
"get-params": "^0.1.2",
"reflect-metadata": "^0.1.12",
"winston": "^3.2.1"
"winston": "3.2.1"
},
"devDependencies": {
"ajv": "^6.5.5",
Expand Down
2 changes: 1 addition & 1 deletion libraries/fabric-shim/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"fabric-shim-api": "2.1.3",
"fs-extra": "8.1.0",
"reflect-metadata": "^0.1.12",
"winston": "^3.2.1",
"winston": "3.2.1",
"yargs": "^13.3.0 ",
"yargs-parser": "^13.1.1"
},
Expand Down

3 comments on commit 81e1123

@makkasu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to fix this without rebuilding from master? I can't install any chaincode (npm ERR! enoent undefined ls-remote -h -t ssh://git@github.com/DABH/diagnostics.git ) until I find a way to use this fix.

@mbwhite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makkasu you can try in your chaincode doing an explicit npm install --save winston@3.2.1 As that is in your top level package JSON 3.2.1 will be installed, it satisfies the ^3.2.1 semver so will be used.

@makkasu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbwhite thanks for the advice and the explanation, that's sorted things for me.

Please sign in to comment.