Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics dependency pointing to git on master #1818

Closed
fertavora opened this issue Jun 22, 2020 · 2 comments
Closed

diagnostics dependency pointing to git on master #1818

fertavora opened this issue Jun 22, 2020 · 2 comments

Comments

@fertavora
Copy link

Please fix
67cd9b5#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

The diagnostics dependency is pointing to git, breaking lots of usages.
fertavora referenced this issue Jun 22, 2020
@DABH
[#1813] Use fork of diagnostics, avoiding indirect storage-engine dep…
67cd9b5 
…endency
@fertavora fertavora changed the title diagnoistics dependency pointing to git on master diagnostics dependency pointing to git on master Jun 22, 2020
@mbleigh
Copy link

mbleigh commented Jun 22, 2020

#1814 was closed by the original opener so I'm throwing my weight in on this new issue.

This change is breaking the Firebase CLI for dozens of our users (in just the last couple days), see issue here.

Please reconsider using a git dependency in a widely used NPM package, or, if you feel it's necessary, please re-release it as a breaking change so that folks who have winston as a dependency or sub-dependency can work around the issue until it can be replaced.

@graduta graduta mentioned this issue Jun 22, 2020
Merged
@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

See #1814

@DABH DABH closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbleigh @DABH @fertavora