Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<cmd> hack to not move the cursor for new pairs #394

Closed
wants to merge 24 commits into from
Closed

<cmd> hack to not move the cursor for new pairs #394

wants to merge 24 commits into from

Conversation

Sam-programs
Copy link
Contributor

@Sam-programs Sam-programs commented Sep 19, 2023

this is a solution for the issue i pointed here
#393 (comment)

the way i fixed this is by adding a command ReservedAutopairsJumptbackpairs which positions the cursor in the correct place after custom pairs
which could also be added as a hotkey for jumping back to the position of the last pair (i don't think anyone needs that tho)
i also removed recursive mapping from my last pr (sorry for the trouble)
the commits are a mix of the old pr commits and this pr's commits as i couldn't fork twice (i am new to prs and i forgot to the delete the last fork)
and there is a test failing on line 82 of test_utils.lua because i used nvim_win_set_cursor
and conflicts because i removed recursive mapping from my last pr

@Sam-programs
Copy link
Contributor Author

Sam-programs commented Sep 20, 2023

I AM SORRY FOR ALL THE ISSUES I MADE USING RECURSIVE MAPPING
i really didn't think users would actually remap the = key or the $ key
i left the = key recursive because i thought maybe some formatters could use it
i overlooked $ and k being an issue so i left them recursive too
never trusting user input again

@windwp
Copy link
Owner

windwp commented Sep 21, 2023

i forget about it too.
can you just delete your branch and create a new pr. now it conflict with another pr

@Sam-programs
Copy link
Contributor Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants