Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd hack to not move the cursor and a fix for recursive mapping #396

Merged
merged 1 commit into from Sep 23, 2023
Merged

cmd hack to not move the cursor and a fix for recursive mapping #396

merged 1 commit into from Sep 23, 2023

Conversation

Sam-programs
Copy link
Contributor

@Sam-programs Sam-programs commented Sep 22, 2023

this fixes =,$ and k mappings being broken (which i made sorry users)
and doesn't move the cursor on custom pairs with a cmd hack
more info:
#394

so yeah here is the new pr with more sane commits windwp
i doubt the test on line 82 of test_utils is gonna pass tho it's probably safe to remove

@windwp
Copy link
Owner

windwp commented Sep 23, 2023

Can you only change normal to normal!
I can't use nvim_api win_set_cursor it will break another thing with undo.

@Sam-programs
Copy link
Contributor Author

Sam-programs commented Sep 23, 2023

i don't notice any changes to undo blocks using set_cursor
i reverted back to the first commit that doesn't have the cmd hack
lets merge this to fix the issues the users are having and if you would like we can discuss the cmd hack later as it seems harmless

@windwp windwp merged commit de4f713 into windwp:master Sep 23, 2023
1 check passed
@windwp
Copy link
Owner

windwp commented Sep 23, 2023

thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants