[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #4311

Skyllarr · 2020-08-31T13:30:31Z

https://issues.redhat.com/browse/WFCORE-5101

Requires: https://issues.redhat.com/browse/ELY-1996 which has PR here: wildfly-security/wildfly-elytron#1382

wildfly-ci · 2020-08-31T13:33:47Z

Core - Full Integration Build 9882 outcome was FAILURE using a merge of 9609837
Summary: Compilation error: Compiler (new) Build time: 00:01:16

wildfly-ci · 2020-08-31T13:33:52Z

Core - Full Integration Build 9930 outcome was FAILURE using a merge of 9609837
Summary: Compilation error: Compiler (new) Build time: 00:01:21

fjuma · 2020-10-01T15:42:57Z

elytron/src/main/java/org/wildfly/extension/elytron/AuthenticationClientDefinitions.java

+                ServiceTarget serviceTarget = context.getServiceTarget();
+                ServiceBuilder<AuthenticationContext> serviceBuilder =
+                        (ServiceBuilder<AuthenticationContext>)context.getCapabilityServiceTarget().addCapability(AUTHENTICATION_CONTEXT_RUNTIME_CAPABILITY);
+                TrivialService<AuthenticationContext> certificateAuthorityTrivialService = new TrivialService<AuthenticationContext>(getValueSupplier(serviceBuilder, context, model));


Very minor but looks like certificateAuthorityTrivialService should be renamed.

Fixed. Thanks!

wildfly-ci · 2020-10-02T12:46:44Z

Core - Full Integration Build 10039 outcome was FAILURE using a merge of b66a3da
Summary: Compilation error: Compiler Build time: 00:00:56

wildfly-ci · 2020-10-02T12:48:01Z

Core - Full Integration Build 10006 outcome was FAILURE using a merge of b66a3da
Summary: Compilation error: Compiler Build time: 00:02:20

wildfly-ci · 2020-10-02T15:41:05Z

Core - Full Integration Build 10040 outcome was FAILURE using a merge of 5bf06d7
Summary: Compilation error: Compiler Build time: 00:01:32

wildfly-ci · 2020-10-02T15:41:15Z

Core - Full Integration Build 10007 outcome was FAILURE using a merge of 5bf06d7
Summary: Compilation error: Compiler Build time: 00:01:42

github-actions · 2020-11-02T00:12:12Z

There has been no activity on this PR for 30 days. It will be auto-closed after 90 days.

jmesnil · 2021-04-08T15:08:40Z

this PR is out of sync with the main branch.
I'm closing it. Please reopen it when it is up to date and can be built.

darranl · 2021-04-08T15:30:36Z

Converted to draft whilst awaiting pre-check

wildfly-ci · 2021-04-09T19:24:51Z

Core - Full Integration Build 10467 outcome was FAILURE using a merge of c3bfb6d
Summary: Compilation error: Compiler (new) Build time: 00:01:19

wildfly-ci · 2021-04-09T19:24:53Z

Core - Full Integration Build 10532 outcome was FAILURE using a merge of c3bfb6d
Summary: Compilation error: Compiler (new) Build time: 00:01:21

wildfly-ci · 2021-04-09T22:18:45Z

Core - Full Integration Build 10469 outcome was FAILURE using a merge of 553a1c1
Summary: Compilation error: Compiler Build time: 00:01:12

wildfly-ci · 2024-03-20T22:16:52Z

Core -> WildFly Preview Integration Build 13445 outcome was FAILURE using a merge of f30aca3
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:44

wildfly-ci · 2024-03-20T22:25:57Z

Core -> Full Integration Build 13638 outcome was FAILURE using a merge of f30aca3
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:47

wildfly-ci · 2024-03-20T22:27:09Z

Core -> Full Integration Build 13389 outcome was FAILURE using a merge of f30aca3
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:11

…ioning

…ldFly Elytron model and schema

wildfly-ci · 2024-03-20T23:46:36Z

Core -> Full Integration Build 13390 outcome was FAILURE using a merge of e562b79
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:23

wildfly-ci · 2024-03-20T23:46:48Z

Core -> WildFly Preview Integration Build 13446 outcome was FAILURE using a merge of e562b79
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:37

wildfly-ci · 2024-03-20T23:46:51Z

Core -> Full Integration Build 13639 outcome was FAILURE using a merge of e562b79
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:40

wildfly-ci · 2024-03-21T00:06:35Z

Core -> WildFly Preview Integration Build 13447 outcome was FAILURE using a merge of 78b28b7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:22

wildfly-ci · 2024-03-21T00:06:43Z

Core -> Full Integration Build 13391 outcome was FAILURE using a merge of 78b28b7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:30

wildfly-ci · 2024-03-21T00:06:44Z

Core -> Full Integration Build 13640 outcome was FAILURE using a merge of 78b28b7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:30

Skyllarr · 2024-03-21T00:21:22Z

@darranl @fjuma Thank you very much for reviews! Just an update that I have addressed some of your comments and I commented on those that I've addressed. The remaining comments I was not able to address before my PTO

darranl · 2024-03-21T16:56:41Z

@fjuma it sounds like the main piece missing here is finishing off the skipping provisioning when not at the community stability level - I think we can move that to a Blocker issue WFCORE / ELY to address before WildFly 32 Final

darranl · 2024-03-21T18:36:07Z

elytron/src/main/java/org/wildfly/extension/elytron/ElytronSubsystemTransformers.java

@@ -170,6 +170,8 @@ private static void from18(ChainedTransformationDescriptionBuilder chainedBuilde
        .setDiscard(DiscardAttributeChecker.UNDEFINED, EMIT_EVENTS)
        .addRejectCheck(new RejectAttributeChecker.SimpleRejectAttributeChecker(ModelNode.TRUE), IGNORE_UNAVAILABLE_REALMS)
        .addRejectCheck(RejectAttributeChecker.DEFINED, EMIT_EVENTS);
+        builder.rejectChildResource(PathElement.pathElement(ElytronDescriptionConstants.DYNAMIC_CLIENT_SSL_CONTEXTS));
+        builder.rejectChildResource(PathElement.pathElement(ElytronDescriptionConstants.DYNAMIC_CLIENT_SSL_CONTEXT));


I think we can add a follow up commit to not block this PR but @pferraro from something you said elsewhere, are we missing a subsystem model bump?

I think you said a change to any resource at any stability level should trigger a bump so we probably need this bumping to 19 so the transformer should then be when transforming from19

I think we can add a follow up commit to not block this PR but @pferraro from something you said elsewhere, are we missing a subsystem model bump?

Yes - this requires a model version bump.
Modifying an existing transformer for a version that was already released will cause regressions.

Created a blocker issue, WFCORE-6756, for this.

elytron/src/test/java/org/wildfly/extension/elytron/TestEnvironment.java

…te instancesbased on peer information.

…xt to avoid dependency on unsupported module

wildfly-ci · 2024-03-21T19:36:27Z

Core -> WildFly Preview Integration Build 13453 outcome was FAILURE using a merge of 8cabe0b
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:13

wildfly-ci · 2024-03-21T19:36:36Z

Core -> Full Integration Build 13646 outcome was FAILURE using a merge of 8cabe0b
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:22

wildfly-ci · 2024-03-21T19:36:46Z

Core -> Full Integration Build 13397 outcome was FAILURE using a merge of 8cabe0b
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:33

fjuma

Adding my approval on this one since I've created WFCORE issues to track the remaining items. The created issues have also been linked from WFCORE-5101.

darranl · 2024-03-25T10:11:53Z

/retest

wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 31, 2020

darranl added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Sep 10, 2020

jmesnil added the 14.x label Sep 28, 2020

fjuma reviewed Oct 1, 2020

View reviewed changes

Skyllarr force-pushed the wfcore-5101 branch from 9609837 to b66a3da Compare October 2, 2020 12:42

Skyllarr force-pushed the wfcore-5101 branch from b66a3da to 5bf06d7 Compare October 2, 2020 15:39

github-actions bot added the Stale label Nov 2, 2020

bstansberry added 15.x and removed 14.x labels Dec 11, 2020

bstansberry added 16.x and removed 15.x labels Feb 19, 2021

jmesnil closed this Apr 8, 2021

darranl reopened this Apr 8, 2021

darranl marked this pull request as draft April 8, 2021 15:30

github-actions bot removed the Stale label Apr 9, 2021

Skyllarr force-pushed the wfcore-5101 branch from 5bf06d7 to c3bfb6d Compare April 9, 2021 19:21

Skyllarr force-pushed the wfcore-5101 branch from c3bfb6d to 553a1c1 Compare April 9, 2021 22:16

Skyllarr force-pushed the wfcore-5101 branch from 4306b8e to f30aca3 Compare March 20, 2024 22:08

Skyllarr added 2 commits March 21, 2024 00:17

[WFCORE-6737] Remove polymorphism from WildFly Elytron subsystem vers…

89eac6a

…ioning

[WFCORE-5101] Add version 18 with COMMUNITY stability level of the Wi…

d7de0dd

…ldFly Elytron model and schema

Skyllarr force-pushed the wfcore-5101 branch from f30aca3 to e562b79 Compare March 20, 2024 23:41

darranl reviewed Mar 21, 2024

View reviewed changes

pferraro requested changes Mar 21, 2024

View reviewed changes

elytron/src/test/java/org/wildfly/extension/elytron/TestEnvironment.java Outdated Show resolved Hide resolved

Skyllarr added 2 commits March 21, 2024 20:30

[WFCORE-5101] [Community] SSLContext to support delegation to alterna…

eb39ba3

…te instancesbased on peer information.

[WFCORE-5101] Use ActiveSessionsSSLContext instead of DynamicSSLConte…

8cabe0b

…xt to avoid dependency on unsupported module

Skyllarr force-pushed the wfcore-5101 branch from 78b28b7 to 8cabe0b Compare March 21, 2024 19:30

fjuma approved these changes Mar 22, 2024

View reviewed changes

This was referenced Mar 25, 2024

Aggregate PR #5918

Closed

[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #5919

Merged

darranl merged commit 8cabe0b into wildfly:main Mar 25, 2024
0 of 12 checks passed

Skyllarr mentioned this pull request Apr 8, 2024

[WFCORE-6756] Subsystem model bump and transformer adjustments needed for the dynamic SSLContext support #5941

Merged

fjuma mentioned this pull request Apr 16, 2024

WFLY-19232 Update ElytronOidcSubsystemSchema to only add the Scope attribute to Preview:2.0 schema version or later wildfly/wildfly#17816

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #4311

[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #4311

Skyllarr commented Aug 31, 2020 •

edited

wildfly-ci commented Aug 31, 2020

wildfly-ci commented Aug 31, 2020

fjuma Oct 1, 2020

Skyllarr Oct 2, 2020

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

github-actions bot commented Nov 2, 2020

jmesnil commented Apr 8, 2021

darranl commented Apr 8, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

Skyllarr commented Mar 21, 2024

darranl commented Mar 21, 2024

darranl Mar 21, 2024

pferraro Mar 21, 2024

fjuma Mar 22, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

fjuma left a comment •

edited

darranl commented Mar 25, 2024

[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #4311

[WFCORE-5101] [Community] SSLContext to support delegation to alternate instances based on peer information. #4311

Conversation

Skyllarr commented Aug 31, 2020 • edited

wildfly-ci commented Aug 31, 2020

wildfly-ci commented Aug 31, 2020

fjuma Oct 1, 2020

Choose a reason for hiding this comment

Skyllarr Oct 2, 2020

Choose a reason for hiding this comment

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

wildfly-ci commented Oct 2, 2020

github-actions bot commented Nov 2, 2020

jmesnil commented Apr 8, 2021

darranl commented Apr 8, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Apr 9, 2021

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 20, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

Skyllarr commented Mar 21, 2024

darranl commented Mar 21, 2024

darranl Mar 21, 2024

Choose a reason for hiding this comment

pferraro Mar 21, 2024

Choose a reason for hiding this comment

fjuma Mar 22, 2024

Choose a reason for hiding this comment

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

wildfly-ci commented Mar 21, 2024

fjuma left a comment • edited

Choose a reason for hiding this comment

darranl commented Mar 25, 2024

Skyllarr commented Aug 31, 2020 •

edited

fjuma left a comment •

edited