WFLY-19232 Update ElytronOidcSubsystemSchema to only add the Scope attribute to Preview:2.0 schema version or later #17816
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
added
Blocker
fjuma
requested changes
Apr 16, 2024
| Stream.of(ProviderAttributeDefinitions.ATTRIBUTES).forEach(attribute -> secureDeploymentDefinitionBuilder.addAttribute(attribute, SIMPLE_ATTRIBUTE_PARSER, SIMPLE_ATTRIBUTE_MARSHALLER)); | ||
| Stream.of(ProviderAttributeDefinitions.ATTRIBUTES).forEach(attribute -> secureServerDefinitionBuilder.addAttribute(attribute, SIMPLE_ATTRIBUTE_PARSER, SIMPLE_ATTRIBUTE_MARSHALLER)); | ||
|
|
||
| if (this.since(VERSION_2_0_PREVIEW)) { |
There was a problem hiding this comment.
The since check only compares version numbers. We should also add a this.enables(...) check, similar to what @Skyllarr did here:
More details about this can also be found here:
…tribute to Preview:2.0 schema version or later
PrarthonaPaul
force-pushed
the
WFLY-19232
branch
from
a163bb4
to
4661982
Compare
|
Thanks @PrarthonaPaul and @fjuma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-19232
More information about the wildfly-bot[bot]