Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2708] Update the CONTRIBUTING.md file with information on Elytron's code review process and maintenance branches #2076

Merged
merged 1 commit into from Mar 8, 2024
Merged

[ELY-2708] Update the CONTRIBUTING.md file with information on Elytron's code review process and maintenance branches #2076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -95,5 +95,17 @@ When submitting a PR, please keep the following guidelines in mind:

For an example of a properly formatted PR, take a look at https://github.com/wildfly-security/wildfly-elytron/pull/1532

## Code Reviews

All submissions, including submissions by project members, need to be reviewed by at least two WildFly Elytron committers before being merged.

The [GitHub Pull Request Review Process](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews) is followed for every pull request.

## Maintenance Branches

If you are working on a fix that's required for a maintenance branch (e.g., a fix for the 1.15.x or 2.2.x branches), please submit
your PR directly against the relevant maintenance branch. Once a fix for a maintenance branch is approved and merged, we then
merge the maintenance branch to the upstream branch to ensure changes are kept in sync.

## Community
For more information on how to get involved with WildFly Elytron, check out our [community](https://wildfly-security.github.io/wildfly-elytron/community/) page.