Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2708] Update the CONTRIBUTING.md file with information on Elytron's code review process and maintenance branches #2076

Merged
merged 1 commit into from Mar 8, 2024

Conversation

fjuma
Copy link
Contributor

@fjuma fjuma commented Dec 7, 2023

@fjuma fjuma requested a review from Skyllarr as a code owner December 7, 2023 19:14
@fjuma fjuma requested a review from darranl December 7, 2023 19:14
@Skyllarr Skyllarr added the +1 DV label Dec 11, 2023
CONTRIBUTING.md Outdated
## Maintenance Branches

If you are working on a fix that's required for a maintenance branch (e.g., a fix for the 1.15.x or 2.2.x branches), please submit
your PR directly against the relevant maintenance branch. Once approved and merged, the fix will then be forward ported to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure in this if it is so much "forward ported" that sounds like the work still exists just in a different direction - maybe mention that we merge from maintenance branches to upstream to ensure changes are kept in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated this.

…n's code review process and maintenance branches
@darranl darranl added the +1 DAL label Mar 8, 2024
@darranl darranl merged commit d0debf7 into wildfly-security:2.x Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants