Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #373: ANIm should not be symmetric #376

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

baileythegreen
Copy link
Contributor

@baileythegreen baileythegreen commented Jan 24, 2022

With this PR, ANIm is no longer treated as symmetric. Comparisons between each pair of genomes are run in both directions; enforced sorting of output file names has been disabled; tests relying on this sorting are skipped; and documentation has been updated.

Closes #373.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update
  • This is a documentation update

Action Checklist

  • Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
  • Fork the pyani repository under your own account (please allow write access for repository maintainers)
  • Set up an appropriate development environment (please see CONTRIBUTING.md)
  • Create a new branch with a short, descriptive name
  • Work on this branch
    • style guidelines have been followed
    • new code is commented, especially in hard-to-understand areas
    • corresponding changes to documentation have been made
    • tests for the change have been added that demonstrate the fix or feature works
  • Test locally with pytest -v non-passing code will not be merged
  • Rebase against origin/master
  • Check changes with flake8 and black before submission
  • Commit branch
  • Submit pull request, describing the content and intent of the pull request
  • Request a code review
  • Continue the discussion at Pull requests section in the pyani repository

@widdowquinn
Copy link
Owner

tests relying on this sorting are skipped

What is the reason for retaining and skipping them? I would have thought deleting/removing the tests would be appropriate.

@baileythegreen
Copy link
Contributor Author

tests relying on this sorting are skipped

What is the reason for retaining and skipping them? I would have thought deleting/removing the tests would be appropriate.

I wanted to think a bit about whether there might be a different use for it (there's really only one such test), or whether it might be usefully repurposed before completely removing it.

@baileythegreen baileythegreen added this to the 0.3.0 milestone May 4, 2022
@baileythegreen baileythegreen marked this pull request as draft May 23, 2022 21:10
@baileythegreen baileythegreen marked this pull request as ready for review May 23, 2022 21:12
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #376 (8d9cc42) into master (62949c4) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   75.82%   75.77%   -0.05%     
==========================================
  Files          55       55              
  Lines        3747     3740       -7     
==========================================
- Hits         2841     2834       -7     
  Misses        906      906              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANIm should not be symmetric
2 participants