Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree 186 #370

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Tree 186 #370

wants to merge 16 commits into from

Conversation

baileythegreen
Copy link
Contributor

@baileythegreen baileythegreen commented Jan 10, 2022

Please include a summary of the change and which issue is fixed. Please also include the motivation and context, and note the tests that apply to these changes.

Closes #187.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update
  • This is a documentation update

Action Checklist

  • Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
  • Fork the pyani repository under your own account (please allow write access for repository maintainers)
  • Set up an appropriate development environment (please see CONTRIBUTING.md)
  • Create a new branch with a short, descriptive name
  • Work on this branch
    • style guidelines have been followed
    • new code is commented, especially in hard-to-understand areas
    • corresponding changes to documentation have been made
    • tests for the change have been added that demonstrate the fix or feature works
  • Test locally with pytest -v non-passing code will not be merged
  • Rebase against origin/master
  • Check changes with flake8 and black before submission
  • Commit branch
  • Submit pull request, describing the content and intent of the pull request
  • Request a code review
  • Continue the discussion at Pull requests section in the pyani repository

@baileythegreen baileythegreen added enhancement something we'd like pyani to do that it doesn't already visualisation issues relating to plot outputs labels Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #370 (1acbdca) into master (1bed428) will decrease coverage by 1.33%.
The diff coverage is 36.08%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   75.82%   74.48%   -1.34%     
==========================================
  Files          55       58       +3     
  Lines        3747     3967     +220     
==========================================
+ Hits         2841     2955     +114     
- Misses        906     1012     +106     

@baileythegreen baileythegreen added this to the 0.3.1 milestone May 4, 2022
@baileythegreen baileythegreen changed the title Tree 186 Tree 187 May 13, 2022
@baileythegreen baileythegreen changed the title Tree 187 Tree 186 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement something we'd like pyani to do that it doesn't already visualisation issues relating to plot outputs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pyani tree subcommand
3 participants