Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #212: Pin Redis to version 2.10.6 #214

Merged
merged 4 commits into from Dec 13, 2018
Merged

Fix #212: Pin Redis to version 2.10.6 #214

merged 4 commits into from Dec 13, 2018

Conversation

ericof
Copy link
Member

@ericof ericof commented Dec 13, 2018

Version 3.0 of Redis breaks Celery, so we need to pin to version 2.10.6

Redis 3.0 release note:

Celery incompatibility with Redis 3.0:

@ericof ericof added the bug label Dec 13, 2018
@codecov-io
Copy link

Codecov Report

Merging #214 into master will increase coverage by 9.69%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   67.69%   77.38%   +9.69%     
==========================================
  Files         132      132              
  Lines        6636     5944     -692     
  Branches      768      632     -136     
==========================================
+ Hits         4492     4600     +108     
+ Misses       1863     1102     -761     
+ Partials      281      242      -39
Impacted Files Coverage Δ
websauna/system/core/redis.py 92.72% <100%> (+1.81%) ⬆️
websauna/utils/autoevent.py 50.9% <0%> (-1.82%) ⬇️
websauna/system/task/celeryloader.py 0% <0%> (ø) ⬆️
websauna/system/model/sqlalchemyutcdatetime.py 0% <0%> (ø) ⬆️
websauna/system/user/googleoauth.py 0% <0%> (ø) ⬆️
websauna/system/user/userregistry.py 92.37% <0%> (+0.84%) ⬆️
websauna/system/user/oauthloginservice.py 36.48% <0%> (+1.35%) ⬆️
websauna/system/user/loginservice.py 94.44% <0%> (+1.38%) ⬆️
websauna/system/model/retry.py 74.6% <0%> (+1.58%) ⬆️
websauna/system/user/social.py 36.73% <0%> (+1.73%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b6e3b...69f21c9. Read the comment docs.

@ericof ericof merged commit 9008d65 into master Dec 13, 2018
@ericof ericof deleted the issue-212 branch December 13, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants