Skip to content

Commit

Permalink
Fix #212: Pin Redis to version 2.10.6 (#214)
Browse files Browse the repository at this point in the history
* Redis 3.0 does not try to coerse boolean to string. (https://github.com/andymccurdy/redis-py/blob/3.0/README.rst)

* Use pytest < 4.0

* Pin redis to 2.10.6

* Update changelog
  • Loading branch information
ericof committed Dec 13, 2018
1 parent 76b6e3b commit 9008d65
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Changelog for Websauna
1.0a13 (unreleased)
-------------------

- Nothing changed yet.
- Closes `Issue #212`_: Pin to Redis version 2.10.6.


1.0a12 (2018-11-01)
Expand Down Expand Up @@ -160,3 +160,4 @@ Changelog for Websauna
.. _`Issue #193`: https://github.com/websauna/websauna/issues/193
.. _`Issue #195`: https://github.com/websauna/websauna/issues/195
.. _`Issue #206`: https://github.com/websauna/websauna/issues/206
.. _`Issue #212`: https://github.com/websauna/websauna/issues/212
5 changes: 4 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@

# Misc
"python-slugify", # ASCII slug generation

# Redis
"redis==2.10.6",
],

extras_require={
Expand All @@ -111,7 +114,7 @@
'pytest-runner',
'pytest-splinter',
'pytest-timeout',
'pytest>=3.0',
'pytest<4.0',
'webtest',
],
"notebook": [
Expand Down
2 changes: 1 addition & 1 deletion websauna/system/core/redis.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def is_sane_redis(config: Configurator) -> bool:
"""
try:
redis = get_redis(config.registry)
redis.set("websauna_session_test", True)
redis.set("websauna_session_test", "success")
return True
except ConnectionError:
return False
Expand Down

0 comments on commit 9008d65

Please sign in to comment.