Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11473] Refactor wdio-allure-reporter package for better hooks handling [v8] #12855

Merged
merged 3 commits into from May 15, 2024

Conversation

lararojasmr
Copy link
Contributor

Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports.

(cherry picked from commit 2bc28ba)

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports.

Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>

(cherry picked from commit 2bc28ba)
Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
This update modifies the wdio-allure-reporter package to better handle errors during test execution. If a step or substep fails, the error message and stack trace are now recorded for the current test. In addition, conditional logging for failed hooks has been implemented, and changes have been made to ensure the correct number of test results are recorded in suite tests.

Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
@lararojasmr
Copy link
Contributor Author

@christian-bromann when this ticket is plan to be merge? Just to know 😀 thanks

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 15, 2024
@christian-bromann christian-bromann merged commit acf6722 into webdriverio:v8 May 15, 2024
10 of 11 checks passed
@lararojasmr
Copy link
Contributor Author

LGTM 👍

when is plan to be released @christian-bromann?

@christian-bromann
Copy link
Member

I can cut a release today.

@lararojasmr
Copy link
Contributor Author

I can cut a release today.

It was released?

@christian-bromann
Copy link
Member

@lararojasmr sorry for the delay, I just triggered a v8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants