Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11473] - Refactor wdio-allure-reporter package for better hooks handling #12852

Merged
merged 7 commits into from May 16, 2024
Merged

[#11473] - Refactor wdio-allure-reporter package for better hooks handling #12852

merged 7 commits into from May 16, 2024

Conversation

lararojasmr
Copy link
Contributor

@lararojasmr lararojasmr commented May 10, 2024 •
edited

Proposed changes

Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

Reviewers: @webdriverio/project-committers

@lararojasmr
Refactor wdio-allure-reporter package for better hooks handling
2bc28ba 
Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports.

Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
@lararojasmr
Copy link
Contributor Author

lararojasmr commented May 10, 2024 •
edited

@christian-bromann is there an issue with pipelines, because i'm not getting those failures in my machine? I'm using a mac. Could you check that please?

I'm getting errors in Bidi test cases

@christian-bromann
Copy link
Member

@lararojasmr yes, I am currently working on fixing the main build. We can move forward with your contribution no matter what. Mind, raising a PR for v8 as well? It can help us verify the changes there.

@lararojasmr lararojasmr mentioned this pull request May 10, 2024
Closed
13 tasks
@lararojasmr
Copy link
Contributor Author

I hope I did it right @christian-bromann if you have time, please confirm.

@lararojasmr
Copy link
Contributor Author

lararojasmr commented May 10, 2024 •
edited

@lararojasmr yes, I am currently working on fixing the main build. We can move forward with your contribution no matter what. Mind, raising a PR for v8 as well? It can help us verify the changes there.

v8: #12855

lararojasmr and others added 5 commits May 11, 2024 04:22
@lararojasmr
Fixes on reporter.ts
b4bba1e 
- Before Hook Failed (Duplicated)
- Inner Step with fail status not propagate the fails details to test.
- Other Validations
@lararojasmr
Update suite.test.ts
0cb15d0 
- Fixes test cases to correct validation after fixing report.ts
@lararojasmr
Update reporter.ts
8ac7a99 
Fixing: 
Error: packages/wdio-allure-reporter/src/reporter.ts(396,23): error TS2451: Cannot redeclare block-scoped variable 'currentTest'.
Error: packages/wdio-allure-reporter/src/reporter.ts(397,23): error TS2451: Cannot redeclare block-scoped variable 'currentTest'.
Error: packages/wdio-allure-reporter/src/reporter.ts(401,17): error TS2304: Cannot find name 'setHistoryId'.
@lararojasmr
Merge branch 'main' into main
e9e22b9
@christian-bromann
Merge branch 'main' into main
8b6b587
christian-bromann
christian-bromann approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 16, 2024
@christian-bromann christian-bromann merged commit 8b07694 into webdriverio:main May 16, 2024
45 checks passed
@wdio-bot
Copy link
Contributor

Hey lararojasmr 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@lararojasmr lararojasmr mentioned this pull request May 21, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
Expensable $50 💸 PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lararojasmr @christian-bromann @wdio-bot