Remove management AngularJS controllers #6555

Desvelao · 2024-03-26T14:04:10Z

Description

This pull request removes the tools and dev tools AngularJS controllers.

Changes:

Remove AngularJS controller of Management
- Remove deprecated listeners
- Remove deprecated methods
- Remove logtestProps from some components that were passed from the
  AngularJS controller
  - Move some methods to ReactJS
Create router to manage the view to display
Change button to render the Ruleset Test or Decoders Test to use a
button that opens a flyout.
Remove the flyout components in the Logtest component

Warning

This pull request depends on #6532.

Issues Resolved

#6549

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Ensure the Server management > Ruleset Test is rendered correctly	⚫	⚫	⚫
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test	⚫	⚫	⚫
Ensure the Server Management > Groups displays the view	⚫	⚫	⚫
Ensure the Server Management > Status displays the view	⚫	⚫	⚫
Ensure the Server Management > Cluster displays the view	⚫	⚫	⚫
Ensure the Server Management > Statistics displays the view	⚫	⚫	⚫
Ensure the Server Management > Logs displays the view	⚫	⚫	⚫
Ensure the Server Management > Configuration displays the view	⚫	⚫	⚫
Ensure the Server Management > CDB Lists displays the view	⚫	⚫	⚫
Ensure the Server Management > Decoders displays the view	⚫	⚫	⚫
Ensure the Server Management > Rules displays the view	⚫	⚫	⚫
Ensure the Dashboard Management > Reporting displays the view	⚫	⚫	⚫

Details

⚫ Ensure the Server management > Ruleset Test is rendered correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Groups displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Status displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Cluster displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Statistics displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Logs displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Configuration displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > CDB Lists displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Decoders displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Rules displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Dashboard Management > Reporting displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

- Remove AngularJS controller of Management - Remove deprecated listeners - Remove deprecated methods - Remove logtestProps from some components that were passed from the AngularJS controller - Move some methods to ReactJS - Create router to manage the view to display - Change button to render the Ruleset Test or Decoders Test to use a button that opens a flyout. - Remove the flyout components in the Logtest component

github-actions · 2024-03-26T14:11:42Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-03-26T14:11:47Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	28.94%	( 286 / 988 )
Branches	26.22%	( 107 / 408 )
Functions	26.87%	( 86 / 320 )
Lines	28.68%	( 278 / 969 )

github-actions · 2024-03-26T14:15:54Z

Main plugin code coverage (Jest) test	%	values
Statements	12.19%	( 4205 / 34485 )
Branches	7.83%	( 1774 / 22642 )
Functions	10.82%	( 887 / 8196 )
Lines	12.38%	( 4094 / 33052 )

…o feat/6549-remove-angularjs-controller-management

JuanGarriuz · 2024-04-24T11:22:54Z

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test	🟢	⚫	⚫
Ensure the Server Management > Groups displays the view	🟢	⚫	⚫
Ensure the Server Management > Status displays the view	🟢	⚫	⚫
Ensure the Server Management > Cluster displays the view	🟢	⚫	⚫
Ensure the Server Management > Statistics displays the view	🟢	⚫	⚫
Ensure the Server Management > Logs displays the view	🟢	⚫	⚫
Ensure the Server Management > Configuration displays the view	🟢	⚫	⚫
Ensure the Server Management > CDB Lists displays the view	🟢	⚫	⚫
Ensure the Server Management > Decoders displays the view	🟢	⚫	⚫
Ensure the Server Management > Rules displays the view	🟢	⚫	⚫
Ensure the Server Management > Ruleset Test displays the view	🟢	⚫	⚫
Ensure the Dashboard Management > Reporting displays the view	🟢	⚫	⚫

Details

🟢 Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Groups displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Status displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Cluster displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Statistics displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Logs displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Configuration displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > CDB Lists displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Decoders displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Rules displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Ruleset Test displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Dashboard Management > Reporting displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz

LGTM!!

lucianogorza · 2024-04-25T20:20:49Z

CR 🟢

UI 🟢

Test	Chrome	Firefox	Safari
Ensure the Server management > Ruleset Test is rendered correctly	🟢	⚫	⚫
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test	🟢	⚫	⚫
Ensure the Server Management > Groups displays the view	🟢	⚫	⚫
Ensure the Server Management > Status displays the view	🟢	⚫	⚫
Ensure the Server Management > Cluster displays the view	🟢	⚫	⚫
Ensure the Server Management > Statistics displays the view	🟢	⚫	⚫
Ensure the Server Management > Logs displays the view	🟢	⚫	⚫
Ensure the Server Management > Settings displays the view	🟢	⚫	⚫
Ensure the Server Management > CDB Lists displays the view	🟢	⚫	⚫
Ensure the Server Management > Decoders displays the view	🟢	⚫	⚫
Ensure the Server Management > Rules displays the view	🟢	⚫	⚫
Ensure the Dashboard Management > Reporting displays the view	🟢	⚫	⚫

Details

🟢 Ensure the Server management > Ruleset Test is rendered correctly

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Groups displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Status displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Cluster displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Statistics displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Logs displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Settings displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > CDB Lists displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Decoders displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Rules displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Dashboard Management > Reporting displays the view

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

…o feat/6549-remove-angularjs-controller-management

lucianogorza

LGTM

…ement

Desvelao self-assigned this Mar 26, 2024

Desvelao changed the title ~~Remove management^CngularJS controllers~~ Remove management AngularJS controllers Mar 26, 2024

Desvelao linked an issue Mar 26, 2024 that may be closed by this pull request

[Remove discover] Refactor AngularJS of management #6549

Closed

Desvelao added 2 commits March 26, 2024 15:08

changelog: add entry

d4f9561

feat(logtest): remove showClose prop in favor to onFlyout

9f7da58

remove(logtest): unused components

c0e11a7

jbiset mentioned this pull request Mar 27, 2024

[Remove discover] Implement embeddable dashboard on server management cluster module #6561

Merged

26 tasks

Desvelao added 4 commits April 23, 2024 12:01

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

32d5839

…o feat/6549-remove-angularjs-controller-management

feat: add comment

66ad504

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

3052b2f

…o feat/6549-remove-angularjs-controller-management

fix(logtest): minor fixes

3da391f

Desvelao marked this pull request as ready for review April 23, 2024 10:58

JuanGarriuz self-requested a review April 23, 2024 11:51

JuanGarriuz previously approved these changes Apr 24, 2024

View reviewed changes

lucianogorza self-requested a review April 25, 2024 20:12

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

6ff09be

…o feat/6549-remove-angularjs-controller-management

Desvelao dismissed JuanGarriuz’s stale review via 6ff09be April 26, 2024 13:35

lucianogorza approved these changes Apr 26, 2024

View reviewed changes

JuanGarriuz approved these changes Apr 26, 2024

View reviewed changes

asteriscos approved these changes Apr 26, 2024

View reviewed changes

Merge branch '4.9.0' into feat/6549-remove-angularjs-controller-manag…

43507f5

…ement

asteriscos merged commit 98c64df into 4.9.0 Apr 26, 2024
1 check passed

asteriscos deleted the feat/6549-remove-angularjs-controller-management branch April 26, 2024 17:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove management AngularJS controllers #6555

Remove management AngularJS controllers #6555

Desvelao commented Mar 26, 2024 •

edited

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

JuanGarriuz commented Apr 24, 2024 •

edited

JuanGarriuz left a comment

lucianogorza commented Apr 25, 2024 •

edited

lucianogorza left a comment

Remove management AngularJS controllers #6555

Remove management AngularJS controllers #6555

Conversation

Desvelao commented Mar 26, 2024 • edited

Description

Issues Resolved

Test

UI

Check List

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

JuanGarriuz commented Apr 24, 2024 • edited

Test

UI

JuanGarriuz left a comment

Choose a reason for hiding this comment

lucianogorza commented Apr 25, 2024 • edited

CR 🟢

UI 🟢

lucianogorza left a comment

Choose a reason for hiding this comment

Desvelao commented Mar 26, 2024 •

edited

JuanGarriuz commented Apr 24, 2024 •

edited

lucianogorza commented Apr 25, 2024 •

edited