Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove discover] Refactor AngularJS of management #6549

Closed
Tracked by #6535
Desvelao opened this issue Mar 25, 2024 · 3 comments · Fixed by #6555
Closed
Tracked by #6535

[Remove discover] Refactor AngularJS of management #6549

Desvelao opened this issue Mar 25, 2024 · 3 comments · Fixed by #6555
Assignees
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Mar 25, 2024

Description

To deprecate angularJS in the plugins we need to refactor the tools and dev tools controllers into a ReactJS component.
The files are located in:

  • /plugins/main/public/controllers/management/management.js
@Desvelao Desvelao changed the title /plugins/main/public/controllers/management/management.js [Remove discover] Refactor AngularJS of management Mar 25, 2024
@Desvelao Desvelao self-assigned this Mar 25, 2024
@Desvelao Desvelao added level/task Task issue type/enhancement Enhancement issue labels Mar 25, 2024
@Desvelao
Copy link
Member Author

Desvelao commented Mar 25, 2024

Analysis

Controller: plugins/main/public/controllers/management/management.js
Listeners:
Deprecated:

  • setCurrentGroup
  • removeCurrentGroup
  • setCurrentRule
  • removeCurrentRule
  • setCurrentDecoder
  • removeCurrentDecoder
  • setCurrentList
  • removeCurrentList
  • setCurrentConfiguration
  • removeCurrentConfiguration
  • viewFileOnly
  • setRestarting
  • removeBlockEdition
  • performRestart
  • removeRestarting

Methods:
Deprecated:

  • setCurrentRule
  • restartCluster
  • restartManager
  • switchFilesSubTab
  • breadCrumbBack
  • changeNode
  • newFile
  • refreshUploadFileProps
  • openUploadFile
  • inArray
  • uploadFiles

Need to move:

  • openCloseFlyout
  • logtestProps

@Desvelao Desvelao linked a pull request Mar 26, 2024 that will close this issue
6 tasks
@Desvelao
Copy link
Member Author

Changes

  • Migrate needed logic to the ReactJS component
  • Create a component to route the views of Management
  • Remove AngularJS controller
  • Replace the AngularJS template content of management by the render of the router component
  • Replace Ruleset Test and Decoder Test button logic to open the flyout with the logtest utility

@Desvelao
Copy link
Member Author

Changes

  • Update the development branch with the last changes of 4.9.0 branch. Resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants