Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view rule alert link #6553

Merged
merged 2 commits into from Mar 26, 2024
Merged

Fix view rule alert link #6553

merged 2 commits into from Mar 26, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 26, 2024 •
edited

Description

This pull request fixes the path of the "View alerts of this rule" so it pre-filters the rule ID in the Threat hunting view.

Issues Resolved

Closes #6551

Evidence

Link:
image

Applied filter:
image

Test

  • Go to Server management -> Rules
  • Click on a rule row to display de details flyout
  • Click on the top right link "View alerts of this rule"
  • Check it opens a new tab in Threat hunting with the rule ID pre-applied filter

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 26, 2024
@asteriscos asteriscos linked an issue Mar 26, 2024 that may be closed by this pull request
View alerts of this rule link is not working #6551
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@JuanGarriuz JuanGarriuz self-requested a review March 26, 2024 11:04
@JuanGarriuz
Copy link
Member

Test

Evidence

image
image

JuanGarriuz
JuanGarriuz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Desvelao
Copy link
Member

Test 🟢

image

Desvelao
Desvelao approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit 94a219a into 4.8.0 Mar 26, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/view-rule-alert-link-6551 branch March 26, 2024 17:47
@asteriscos asteriscos mentioned this pull request Apr 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View alerts of this rule link is not working
3 participants
@asteriscos @JuanGarriuz @Desvelao