Build assets on release #6982
Merged
Build assets on release #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
commented
Sep 25, 2023
Comment on lines
+32
to
+36
| - name: "Install Node" | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: ".nvmrc" | ||
| cache: "yarn" |
There was a problem hiding this comment.
copied from the Assets workflow haha
yguedidi
commented
Sep 25, 2023
Comment on lines
+13
to
+14
| cd "$TMP_FOLDER"/"$RELEASE_FOLDER"/"$VERSION" && yarn install --non-interactive | ||
| cd "$TMP_FOLDER"/"$RELEASE_FOLDER"/"$VERSION" && yarn run --non-interactive build:prod |
There was a problem hiding this comment.
tested those commands locally and they work
This was referenced Sep 25, 2023
Draft
j0k3r
reviewed
Sep 27, 2023
@j0k3r yes! but wanted to have this merged first and see it working in the next release before cleaning the code :) |
|
I think you can clean it right now :) |
|
@j0k3r answering you I realize that with assets still in the repo the release will work anyway... 😅 so I'll clean now |
yguedidi
force-pushed
the
build-assets-on-release
branch
from
4b4030e
to
7526069
Compare
j0k3r
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming the release script is used only through the GitHub action
similar to wallabag/docker#362 but for ZIP releases