Use the release archive instead of the git archive #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
commented
Aug 15, 2023
yguedidi
commented
Aug 15, 2023
j0k3r
reviewed
Aug 21, 2023
|
rebased |
yguedidi
force-pushed
the
build-assets
branch
from
5cce2fe
to
f2df344
Compare
yguedidi
commented
Sep 25, 2023
j0k3r
reviewed
Sep 27, 2023
yguedidi
force-pushed
the
build-assets
branch
from
f2df344
to
92788d6
Compare
yguedidi
force-pushed
the
build-assets
branch
from
92788d6
to
5bde344
Compare
yguedidi
changed the title
j0k3r
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to build assets as part of the building of the docker image.Use the release archive as assets are now removed from the repository, see wallabag/wallabag#6982
This will help to avoid having built assets versionned in the git source code and avoid hack like this one in the proposal to use Webpack Encore