fix nil pointer panic when evict #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XS
bibibox
force-pushed
the
fix-nil-pointer
branch
from
80ad074
to
50c30e3
Compare
|
/lgtm |
Signed-off-by: Wenbo Zhang <zhangwenbo40@huawei.com>
bibibox
force-pushed
the
fix-nil-pointer
branch
from
50c30e3
to
494bdb4
Compare
|
@bibibox Please log a issue and add the panic description and add the reproduce step :) |
|
/lgtm |
lowang-bh
approved these changes
Apr 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i met panic when i use volcano, it shows there are nil pointer deference when excuting the cache's function Evict:
Maybe we should check if the job.PodGroup is nil before calling Convert function
The more information: #3445