Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add image registry for helm #3436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add image registry for helm #3436

wants to merge 1 commit into from
+7 −5

Conversation

calvin0327
Copy link

There are two scenarios where we need to set up the registry for the image:

  1. image proxy: It is slow to pull a image from docker.io, so we need to switch a proxy.
  2. Offline environment: load volcano images we need to a private repository and set up a new registry.

@volcano-sh-bot
Copy link
Contributor

Welcome @calvin0327!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@calvin0327
Copy link
Author

/auto-cc

@calvin0327
add image registry for helm
5bb9ecb 
Signed-off-by: calvin <wen.chen@daocloud.io>
hwdef
hwdef reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@hwdef
Copy link
Member

hwdef commented Apr 25, 2024

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 25, 2024
@calvin0327
Copy link
Author

@hwdef the label /ok-to-test is not work :)

@calvin0327
Copy link
Author

@lowang-bh @hwdef PTAL

@hwdef
Copy link
Member

hwdef commented Apr 28, 2024

@Monokaix @william-wang please trigger the CI

william-wang
william-wang approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@william-wang
Copy link
Member

please fix the ci failure:)

@Monokaix
Copy link
Member

Monokaix commented May 8, 2024

Hi, please follow the instruction https://github.com/volcano-sh/volcano/actions/runs/8826758139/job/24720544631?pr=3436#step:5:141 to make ci happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@Yikun Yikun Awaiting requested review from Yikun

@huone1 huone1 Awaiting requested review from huone1

@jiangkaihua jiangkaihua Awaiting requested review from jiangkaihua

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@calvin0327 @volcano-sh-bot @hwdef @william-wang @Monokaix