New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-action-event #3433
base: master
Are you sure you want to change the base?
add-action-event #3433
Conversation
Signed-off-by: molei20021 <molei21st@hotmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @lowang-bh |
This is the latest branch. Please take a look. @lowang-bh @googs1025 |
you can close #3405 or use rebase command git rebase -i HEAD~2 2 means you want to rebase commit number
or
git pull origin master --rebase |
I have closed 3405. there are some conflicts in that pr |
I am not sure whether it is necessary to do that? |
For example, there are queue1(task1 > task2 > task3 > task4) and queue2(task5 > task6 > task7 > task8). I want task1 and task5 to try schedule first global. So I need the information of whether task1 and task5 has tried to schedule In queue order plugin. Even if queue1 > queue2 and task1 is scheduled, I will force make queue2 > queue1 to schedule task5. The information of whether task is processed by action can by notified by event I added. |
Hi, this seems conflict with queue design and a little ugly, and the current design is better, if you really need the feature, please give a design detail and re-implement it: ) |
Yeah, I have seen that, but this implement is a little ugly and misunderstanding. |
No description provided.