Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: continue allocating if remain tasks is more than job's minMember #3430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Apr 21, 2024

Consider this scene:
part of pods of a job is not schedulable, and left pods are schedulable, and the number can meet up the condition of min member.

So this pr fix this issue: if allocated pod less than minMember and tasks are not used up, will continue on, untill the number of remained tasks can not meet up the condition of min member

commit 1: continue allocating and testcases about the feature change
commit 2: use string type to replace the taskID type, which indicate a role spec of each task in a job

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lowang-bh
You can assign the PR to them by writing /assign @lowang-bh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2024
@lowang-bh
Copy link
Member Author

/assign @Monokaix @hwdef @william-wang

@lowang-bh lowang-bh changed the title improve: continue allocating if allocated pod less than minMember and… improve: continue allocating if left tasks is more than job's minMember Apr 21, 2024
@lowang-bh lowang-bh changed the title improve: continue allocating if left tasks is more than job's minMember improve: continue allocating if remain tasks is more than job's minMember Apr 21, 2024
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR does two things. But use one commit

… tasks are not used up

Signed-off-by: lowang-bh <lhui_wang@163.com>
…tring and has nothing to do with taskID

Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
Copy link
Member Author

It looks like this PR does two things. But use one commit

Have splited them into two commits.

@lowang-bh
Copy link
Member Author

@Monokaix @hwdef @wangyang0616 @william-wang please help to review it. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants