add ut for pkg/controllers/job/plugins #3422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/L
|
googs1025
force-pushed
the
job_controller_plugin_ut
branch
from
f74473c
to
5a62ee3
Compare
|
I noticed that the test coverage in pkg/controllers can be improved. I will submit separate PRs to enhance this aspect. |
googs1025
force-pushed
the
job_controller_plugin_ut
branch
from
5a62ee3
to
fd96069
Compare
Monokaix
reviewed
Apr 19, 2024
hwdef
reviewed
Apr 25, 2024
hwdef
reviewed
Apr 25, 2024
googs1025
force-pushed
the
job_controller_plugin_ut
branch
from
fd96069
to
6f93dbf
Compare
lowang-bh
reviewed
Apr 25, 2024
googs1025
force-pushed
the
job_controller_plugin_ut
branch
2 times, most recently
from
9ad9b2a
to
6f86cdb
Compare
lowang-bh
reviewed
May 7, 2024
Signed-off-by: googs1025 <googs1025@gmail.com>
googs1025
force-pushed
the
job_controller_plugin_ut
branch
from
6f86cdb
to
403bd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
unit test
What this PR does / why we need it:
Which issue(s) this PR fixes:
See more detail #3053 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: