Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log info or error print #3410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: log info or error print #3410

wants to merge 1 commit into from
+18 −21

Conversation

googs1025
Copy link
Contributor

  • found some typo or code style err
  • fix log print level

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2024
@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from d3b8de4 to 0c42e04 Compare April 13, 2024 17:12
@googs1025
Copy link
Contributor Author

/restart

@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from f444538 to 3888c02 Compare April 14, 2024 05:09
lowang-bh
lowang-bh reviewed Apr 16, 2024
View reviewed changes
pkg/scheduler/actions/reclaim/reclaim.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/backfill/backfill.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/reclaim/reclaim.go Outdated Show resolved Hide resolved
@lowang-bh
Copy link
Member

others lgtm
/assign @Monokaix @hwdef

@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from 8318f99 to f763733 Compare April 16, 2024 05:25
@googs1025
Copy link
Contributor Author

@Monokaix @hwdef /PTAL just fix typo and log level

@lowang-bh
Copy link
Member

/lgtm

Please rebase and squash commits to only one.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@googs1025
Copy link
Contributor Author

@lowang-bh done

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lowang-bh
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hwdef
hwdef reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@googs1025
fix: log info or error print
d1de3df 
Signed-off-by: googs1025 <googs1025@gmail.com>

fix: log level

Signed-off-by: googs1025 <googs1025@gmail.com>
@googs1025 googs1025 requested review from Monokaix and hwdef May 6, 2024 13:26
Monokaix
Monokaix reviewed May 7, 2024
View reviewed changes
pkg/scheduler/actions/allocate/allocate.go
@@ -181,7 +181,7 @@ func (alloc *Action) allocateResourcesForTasks(tasks *util.PriorityQueue, job *a
klog.V(3).Infof("There are <%d> nodes for Job <%v/%v>", len(ssn.Nodes), job.Namespace, job.Name)

if err := ssn.PrePredicateFn(task); err != nil {
klog.V(3).Infof("PrePredicate for task %s/%s failed for: %v", task.Namespace, task.Name, err)
klog.V(4).Infof("PrePredicate for task %s/%s failed for: %v", task.Namespace, task.Name, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log levels are different in this file, we'd better unify them to the same, but whether to 3 or 4 need to be discussed, so does other file like recalim: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@lowang-bh lowang-bh lowang-bh approved these changes

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@archlitchi archlitchi Awaiting requested review from archlitchi

@hwdef hwdef Awaiting requested review from hwdef

At least 1 approving review is required to merge this pull request.

Assignees

@hwdef hwdef

@Monokaix Monokaix

@lowang-bh lowang-bh

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@googs1025 @lowang-bh @volcano-sh-bot @hwdef @Monokaix