Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: add rwlock to fakeBinder and fakeEvictor #3409

Merged
merged 1 commit into from May 7, 2024
Merged

improve: add rwlock to fakeBinder and fakeEvictor #3409

merged 1 commit into from May 7, 2024
+154 −51

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Apr 13, 2024 •
edited

  1. Using rwlock for fakeBinder/fakeEvictor
  2. Add New method for fakeBinder/fakeEvictor to return a new instance
  3. Add extra unepected results checking for binding/evicting in uthelper, in case gorotine is not scheduled to run

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2024
@lowang-bh lowang-bh changed the title improve: add rwlock to fakebinder and fakeevictor improve: add rwlock to fakeBinder and fakeEvictor Apr 13, 2024
@lowang-bh
Copy link
Member Author

/assign @william-wang @Monokaix

@lowang-bh
Copy link
Member Author

lowang-bh commented Apr 13, 2024 •
edited

/priority critical-urgent

@volcano-sh-bot volcano-sh-bot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 13, 2024
@lowang-bh
Copy link
Member Author

/assign @hwdef

hwdef
hwdef reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@lowang-bh
improve: add rwlock to fakebinder and fakeevictor
5fa8a3a 
Signed-off-by: lowang-bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@Monokaix
Copy link
Member

Monokaix commented May 7, 2024

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
william-wang
william-wang approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@volcano-sh-bot volcano-sh-bot merged commit abc1646 into volcano-sh:master May 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Monokaix Monokaix Monokaix left review comments

@william-wang william-wang william-wang approved these changes

@hudson741 hudson741 Awaiting requested review from hudson741

Assignees

@william-wang william-wang

@hwdef hwdef

@Monokaix Monokaix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lowang-bh @Monokaix @volcano-sh-bot @william-wang @hwdef