New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device share plugins npe #3351
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @k82cn |
@@ -18,11 +18,12 @@ package deviceshare | |||
|
|||
import ( | |||
"fmt" | |||
"reflect" | |||
"volcano.sh/volcano/pkg/scheduler/api/devices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please sort the imports.
@@ -100,7 +100,7 @@ func NewGPUDevices(name string, node *v1.Node) *GPUDevices { | |||
klog.Infof("node %v device %s leave", node.Name, handshake) | |||
|
|||
tmppat := make(map[string]string) | |||
tmppat[handshake] = "Deleted_" + time.Now().Format("2006.01.02 15:04:05") | |||
tmppat[VolcanoVGPUHandshake] = "Deleted_" + time.Now().Format("2006.01.02 15:04:05") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archlitchi plz check this changes. I am not familiar with this vgpu feaure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, i didn't noticed that, thanks for fixing:)
/ok-to-test |
please squash commits to one commit. |
2、Fix vgpu device handshake patch error
Hi, please sign off your commit with |
@coldzerofear: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is an NPE issue with the device share plugin, #3241 Not really solving the problem
unit testing
Output results
This does not meet expectations